You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Thomas D'Silva (JIRA)" <ji...@apache.org> on 2015/07/01 22:09:04 UTC
[jira] [Commented] (PHOENIX-2088) Prevent splitting and recombining
select expressions for MR integration
[ https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610928#comment-14610928 ]
Thomas D'Silva commented on PHOENIX-2088:
-----------------------------------------
[~maghamravikiran@gmail.com]
If we have an index on an expression the index column name can contain characters like '|' or ','.
This causes issues with the way we serialize columns PhoenixConfigurationUtil.setUpsertColumnNames()
and ColumnInfoToStringEncoderDecoder .
One way to fix this is to use a delimiter that won't be used in an expression, but this seems like it might break if we ever add a function/operator that uses the delimiter.
Do you know if there is a better way to fix this?
> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
> Key: PHOENIX-2088
> URL: https://issues.apache.org/jira/browse/PHOENIX-2088
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
>
> We currently send in the select expressions for the MR integration with a delimiter separated string, split based on the delimiter, and then recombine again using a comma separator. This is problematic because the delimiter character may appear in a select expression, thus breaking this logic. Instead, we should use a comma as the delimiter and avoid splitting and recombining as it's not necessary in that case. Instead, the entire string can be used as-is in that case to form the select expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)