You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "chadongmin (via GitHub)" <gi...@apache.org> on 2025/08/02 07:40:25 UTC
[PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
chadongmin opened a new pull request, #5007:
URL: https://github.com/apache/zeppelin/pull/5007
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
*Please leave your type of PR only*
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update?
* Is there breaking changes for older versions?
* Does this needs documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "chadongmin (via GitHub)" <gi...@apache.org>.
chadongmin commented on code in PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007#discussion_r2250788848
##########
zeppelin-server/src/test/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealmTest.java:
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zeppelin.realm.jwt;
+
+import com.nimbusds.jose.JWSAlgorithm;
+import com.nimbusds.jose.JWSHeader;
+import com.nimbusds.jose.JWSSigner;
+import com.nimbusds.jose.crypto.RSASSASigner;
+import com.nimbusds.jwt.JWTClaimsSet;
+import com.nimbusds.jwt.SignedJWT;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Date;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class KnoxJwtRealmTest {
+
+ private KnoxJwtRealm knoxJwtRealm;
+
+ @BeforeEach
+ void setUp() throws Exception {
+ knoxJwtRealm = new KnoxJwtRealm();
+ }
+
+ private SignedJWT createJWT(String subject, Date expiration) throws Exception {
+ JWTClaimsSet.Builder claimsBuilder = new JWTClaimsSet.Builder()
+ .subject(subject)
+ .issuer("KNOXSSO")
+ .issueTime(new Date());
+
+ if (expiration != null) {
+ claimsBuilder.expirationTime(expiration);
+ }
+
+ JWTClaimsSet claimsSet = claimsBuilder.build();
+ SignedJWT signedJWT = new SignedJWT(
+ new JWSHeader.Builder(JWSAlgorithm.RS256).build(),
+ claimsSet
+ );
+
+ // Note: We don't sign the JWT for these tests as we're only testing expiration validation
+ return signedJWT;
+ }
+
+ @Test
+ void testValidateExpiration_WithNullExpiration_ShouldReturnFalse() throws Exception {
+ // Given: JWT token without expiration time
+ SignedJWT jwtWithoutExpiration = createJWT("testuser", null);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithoutExpiration);
+
+ // Then: should return false
+ assertFalse(result, "JWT token without expiration time should be rejected");
+ }
+
+ @Test
+ void testValidateExpiration_WithValidFutureExpiration_ShouldReturnTrue() throws Exception {
+ // Given: JWT token with future expiration
+ Date futureDate = new Date(System.currentTimeMillis() + 3600000); // 1 hour from now
+ SignedJWT jwtWithValidExpiration = createJWT("testuser", futureDate);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithValidExpiration);
+
+ // Then: should return true
+ assertTrue(result, "JWT token with valid future expiration should be accepted");
+ }
+
+ @Test
+ void testValidateExpiration_WithPastExpiration_ShouldReturnFalse() throws Exception {
+ // Given: JWT token with past expiration
+ Date pastDate = new Date(System.currentTimeMillis() - 3600000); // 1 hour ago
+ SignedJWT jwtWithPastExpiration = createJWT("testuser", pastDate);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithPastExpiration);
+
+ // Then: should return false
+ assertFalse(result, "JWT token with past expiration should be rejected");
+ }
+
+ // Note: Full token validation tests are omitted as they require complex setup
+ // including certificate files and signature validation. The core expiration
+ // validation logic is tested above through direct method calls.
+}
Review Comment:
I have applied the changes you suggested. I really appreciate you taking the time to review it so carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6266] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007#issuecomment-3154631920
I changed the title to ZEPPELIN-6266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on code in PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007#discussion_r2250760522
##########
zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealm.java:
##########
@@ -192,7 +192,11 @@ protected boolean validateExpiration(SignedJWT jwtToken) {
boolean valid = false;
try {
Date expires = jwtToken.getJWTClaimsSet().getExpirationTime();
- if (expires == null || new Date().before(expires)) {
+ if (expires == null) {
+ LOGGER.warn("JWT token has no expiration time - rejecting token for security");
+ return false;
+ }
+ if (new Date().before(expires)) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("SSO token expiration date has been " + "successfully validated");
Review Comment:
Can you correct the logging at this point?
- Remove string concatenation
- Remove the if before
##########
zeppelin-server/src/test/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealmTest.java:
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zeppelin.realm.jwt;
+
+import com.nimbusds.jose.JWSAlgorithm;
+import com.nimbusds.jose.JWSHeader;
+import com.nimbusds.jose.JWSSigner;
+import com.nimbusds.jose.crypto.RSASSASigner;
+import com.nimbusds.jwt.JWTClaimsSet;
+import com.nimbusds.jwt.SignedJWT;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Date;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class KnoxJwtRealmTest {
+
+ private KnoxJwtRealm knoxJwtRealm;
+
+ @BeforeEach
+ void setUp() throws Exception {
+ knoxJwtRealm = new KnoxJwtRealm();
+ }
+
+ private SignedJWT createJWT(String subject, Date expiration) throws Exception {
+ JWTClaimsSet.Builder claimsBuilder = new JWTClaimsSet.Builder()
+ .subject(subject)
+ .issuer("KNOXSSO")
+ .issueTime(new Date());
+
+ if (expiration != null) {
+ claimsBuilder.expirationTime(expiration);
+ }
+
+ JWTClaimsSet claimsSet = claimsBuilder.build();
+ SignedJWT signedJWT = new SignedJWT(
+ new JWSHeader.Builder(JWSAlgorithm.RS256).build(),
+ claimsSet
+ );
+
+ // Note: We don't sign the JWT for these tests as we're only testing expiration validation
+ return signedJWT;
+ }
+
+ @Test
+ void testValidateExpiration_WithNullExpiration_ShouldReturnFalse() throws Exception {
+ // Given: JWT token without expiration time
+ SignedJWT jwtWithoutExpiration = createJWT("testuser", null);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithoutExpiration);
+
+ // Then: should return false
+ assertFalse(result, "JWT token without expiration time should be rejected");
+ }
+
+ @Test
+ void testValidateExpiration_WithValidFutureExpiration_ShouldReturnTrue() throws Exception {
+ // Given: JWT token with future expiration
+ Date futureDate = new Date(System.currentTimeMillis() + 3600000); // 1 hour from now
+ SignedJWT jwtWithValidExpiration = createJWT("testuser", futureDate);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithValidExpiration);
+
+ // Then: should return true
+ assertTrue(result, "JWT token with valid future expiration should be accepted");
+ }
+
+ @Test
+ void testValidateExpiration_WithPastExpiration_ShouldReturnFalse() throws Exception {
+ // Given: JWT token with past expiration
+ Date pastDate = new Date(System.currentTimeMillis() - 3600000); // 1 hour ago
+ SignedJWT jwtWithPastExpiration = createJWT("testuser", pastDate);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithPastExpiration);
+
+ // Then: should return false
+ assertFalse(result, "JWT token with past expiration should be rejected");
+ }
+
+ // Note: Full token validation tests are omitted as they require complex setup
+ // including certificate files and signature validation. The core expiration
+ // validation logic is tested above through direct method calls.
+}
Review Comment:
Please insert a new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "chadongmin (via GitHub)" <gi...@apache.org>.
chadongmin commented on PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007#issuecomment-3151208404
@Reamer I was wondering what the merge schedule for this PR after it's approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "chadongmin (via GitHub)" <gi...@apache.org>.
chadongmin commented on PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007#issuecomment-3149632270
> Looks good to me. Just a few minor things.
I have applied the changes you suggested. I really appreciate you taking the time to review it so carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "chadongmin (via GitHub)" <gi...@apache.org>.
chadongmin commented on code in PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007#discussion_r2250788848
##########
zeppelin-server/src/test/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealmTest.java:
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zeppelin.realm.jwt;
+
+import com.nimbusds.jose.JWSAlgorithm;
+import com.nimbusds.jose.JWSHeader;
+import com.nimbusds.jose.JWSSigner;
+import com.nimbusds.jose.crypto.RSASSASigner;
+import com.nimbusds.jwt.JWTClaimsSet;
+import com.nimbusds.jwt.SignedJWT;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Date;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class KnoxJwtRealmTest {
+
+ private KnoxJwtRealm knoxJwtRealm;
+
+ @BeforeEach
+ void setUp() throws Exception {
+ knoxJwtRealm = new KnoxJwtRealm();
+ }
+
+ private SignedJWT createJWT(String subject, Date expiration) throws Exception {
+ JWTClaimsSet.Builder claimsBuilder = new JWTClaimsSet.Builder()
+ .subject(subject)
+ .issuer("KNOXSSO")
+ .issueTime(new Date());
+
+ if (expiration != null) {
+ claimsBuilder.expirationTime(expiration);
+ }
+
+ JWTClaimsSet claimsSet = claimsBuilder.build();
+ SignedJWT signedJWT = new SignedJWT(
+ new JWSHeader.Builder(JWSAlgorithm.RS256).build(),
+ claimsSet
+ );
+
+ // Note: We don't sign the JWT for these tests as we're only testing expiration validation
+ return signedJWT;
+ }
+
+ @Test
+ void testValidateExpiration_WithNullExpiration_ShouldReturnFalse() throws Exception {
+ // Given: JWT token without expiration time
+ SignedJWT jwtWithoutExpiration = createJWT("testuser", null);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithoutExpiration);
+
+ // Then: should return false
+ assertFalse(result, "JWT token without expiration time should be rejected");
+ }
+
+ @Test
+ void testValidateExpiration_WithValidFutureExpiration_ShouldReturnTrue() throws Exception {
+ // Given: JWT token with future expiration
+ Date futureDate = new Date(System.currentTimeMillis() + 3600000); // 1 hour from now
+ SignedJWT jwtWithValidExpiration = createJWT("testuser", futureDate);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithValidExpiration);
+
+ // Then: should return true
+ assertTrue(result, "JWT token with valid future expiration should be accepted");
+ }
+
+ @Test
+ void testValidateExpiration_WithPastExpiration_ShouldReturnFalse() throws Exception {
+ // Given: JWT token with past expiration
+ Date pastDate = new Date(System.currentTimeMillis() - 3600000); // 1 hour ago
+ SignedJWT jwtWithPastExpiration = createJWT("testuser", pastDate);
+
+ // When: validating expiration
+ boolean result = knoxJwtRealm.validateExpiration(jwtWithPastExpiration);
+
+ // Then: should return false
+ assertFalse(result, "JWT token with past expiration should be rejected");
+ }
+
+ // Note: Full token validation tests are omitted as they require complex setup
+ // including certificate files and signature validation. The core expiration
+ // validation logic is tested above through direct method calls.
+}
Review Comment:
I have applied the changes you suggested. I really appreciate you taking the time to review it so carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6626] Fix JWT expiration validation security vulnerability [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #5007:
URL: https://github.com/apache/zeppelin/pull/5007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org