You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/15 12:49:42 UTC
[GitHub] [incubator-iotdb] yuqi1129 opened a new pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website
yuqi1129 opened a new pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on a change in pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on a change in pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737#discussion_r493341013
##########
File path: site/pom.xml
##########
@@ -39,30 +39,6 @@
</distributionManagement>
<build>
<plugins>
- <!-- copy source codes into vue required folders-->
Review comment:
You are right, i mistake it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737#discussion_r489137977
##########
File path: hadoop/pom.xml
##########
@@ -85,26 +85,6 @@
</archive>
</configuration>
</plugin>
- <plugin>
Review comment:
this plugin is for generating `hadoop-tsfile-0.11.0-SNAPSHOT-jar-with-dependencies.jar` file, which includes all dependencies for using hdfs and tsfile.
If the user uses maven, indeed it is useless, but for users who are not use maven, I think it is useful (or someone who uses maven but there are version conflicts for hadoop dependencies).
So, I have no idea about whether to remove this plugin? either is ok.
What do you think?
##########
File path: hadoop/pom.xml
##########
@@ -40,7 +40,7 @@
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>tsfile</artifactId>
- <version>0.11.0-SNAPSHOT</version>
Review comment:
+1
##########
File path: site/pom.xml
##########
@@ -39,30 +39,6 @@
</distributionManagement>
<build>
<plugins>
- <!-- copy source codes into vue required folders-->
Review comment:
Hi, why you thought this is duplicated...
have you tried `mvn package -pl site -P site` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737#issuecomment-697320607
This pull pull is mark as invalid, close it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 closed pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website
Posted by GitBox <gi...@apache.org>.
yuqi1129 closed pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on a change in pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on a change in pull request #1737:
URL: https://github.com/apache/incubator-iotdb/pull/1737#discussion_r493510464
##########
File path: hadoop/pom.xml
##########
@@ -85,26 +85,6 @@
</archive>
</configuration>
</plugin>
- <plugin>
Review comment:
Ok, if `hadoop-tsfile-0.11.0-SNAPSHOT-jar-with-dependencies.jar` is needed somewhere, i do think there is no enough reason to remove it.
Thanks for your kindly review~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org