You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 15:17:13 UTC
[GitHub] [arrow] jonkeane opened a new pull request, #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
jonkeane opened a new pull request, #12887:
URL: https://github.com/apache/arrow/pull/12887
Disabling the tests for now, 3.4 will no longer be in our support window shortly with the release of 4.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099299346
```
Invalid group(s) {'test-r-versions'}. Must be one of {'linux', 'verify-rc-source', 'cpp', 'verify-rc-jars', 'verify-rc', 'wheel', 'verify-rc-source-linux', 'python', 'r', 'example', 'vcpkg', 'linux-amd64', 'conda', 'homebrew', 'example-cpp', 'ruby', 'verify-rc-binaries', 'nightly-tests', 'test', 'linux-arm64', 'nightly-packaging', 'c-glib', 'integration', 'verify-rc-wheels', 'packaging', 'nightly-release', 'fuzz', 'nightly', 'verify-rc-source-macos'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2168061224```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099292986
@github-actions crossbow submit -g test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
URL: https://github.com/apache/arrow/pull/12887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099465196
Revision: 0d5057f0b033b72f0fd6258a10cda49419d174fb
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1861](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1861)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1861-github-test-r-versions)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099296512
https://issues.apache.org/jira/browse/ARROW-16201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1100586303
Benchmark runs are scheduled for baseline = 76e4f53679c5b4bbc1b26b3dd181ec990f7b9223 and contender = 63d2a9c856969a2c05e12ae8857a135bceaf45c1. 63d2a9c856969a2c05e12ae8857a135bceaf45c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1dd6587cec254357b0d6c781f5c1b615...bcc9b667d330444f957aa2bdccc22c98/)
[Finished :arrow_down:0.08% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2376bda5e0d44b038ba6aa21c734a39b...59744302e8364352bd1c0f648a52f434/)
[Failed :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b0571066ee6246a4ac98110b710791b4...1a7a8a2ebbd54515ac1a59ca02558da0/)
[Finished :arrow_down:0.38% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ccb5607aa5f4434c9bac5b3231631c06...30fc2cb0ec8c4a3c90865eafdd624583/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/518| `63d2a9c8` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/505| `63d2a9c8` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/504| `63d2a9c8` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/515| `63d2a9c8` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/517| `76e4f536` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/504| `76e4f536` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/503| `76e4f536` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/514| `76e4f536` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099329872
Revision: e20d1796791514da4de22aa530970ceff0ca0a34
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1857](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1857)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1857-github-test-r-versions)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099464242
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099430441
Revision: 975bdd5e7528611bc9d395dda98c9f89b9bf910d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1860](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1860)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1860-github-test-r-versions)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099424191
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #12887:
URL: https://github.com/apache/arrow/pull/12887#issuecomment-1099312914
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on a diff in pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on code in PR #12887:
URL: https://github.com/apache/arrow/pull/12887#discussion_r850730991
##########
r/tests/testthat/test-safe-call-into-r.R:
##########
@@ -46,6 +46,7 @@ test_that("SafeCallIntoR works within RunWithCapturedR", {
})
test_that("SafeCallIntoR errors from the non-R thread", {
+ skip_if_r_version("3.4.4")
Review Comment:
This should still get skipped, but I can also make sure that we error instead of crash `#if !defined(HAS_UNWIND_PROTECT)` (probably more important for https://github.com/apache/arrow/pull/12323 since we'll be actually using it there). Actually, that PR is probably a better place to fix it (I'll make sure to rebase and run the test-r-versions on that PR on Monday).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org