You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "drccrd (via GitHub)" <gi...@apache.org> on 2026/07/06 20:30:08 UTC
[PR] Docs 6779 declared type extends java [incubator-kie-docs]
drccrd opened a new pull request, #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594
resolves: #incubator-kie-drools#6779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594#issuecomment-4910987130
@drccrd In `ExtendsTest.testGeneratedMethods` and `ExtendsTest.testDeepExt`, `@position` is used in declared types, not Java classes.
Rather, `DeclaredTypesTest.testExtendPojoInheritedFieldsConstructor` (which you wrote) is the test case with `@Position` on `PositionalParent`. Indeed the test passes with non-exec-model and exec-model. However, if I add `@Position(2) private long salary;` to `PositionalParent` and change the constructor in the DRL to `new Child("Mario", 40, 50l,"Sales")`, non-exec-model failed while exec-model succeeded. Please try. (if not fail, add more fields)
So I'd say non-exec-model constructor arg order is non-deterministic, not respecting `@Position`. `ClassDefinitionFactory.populateDefinitionFromClass` seems to handle `@Position`, but is not actually effective in the end. You may raise a PR if you want to fix. (We are not eagerly fix issues in non-exec-model as it's deprecated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594#issuecomment-4903274835
@tkobayas yes I can add a note explaining the difference between the two models. However my understanding is the the legacy model also respects position, only not exclusively, judging by the code in `ClassDefinitionFactory` (it is also included in `ExtendsTest.java`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594#issuecomment-4966637246
FYI)
> So I'd say non-exec-model constructor arg order is non-deterministic, not respecting `@Position`. `ClassDefinitionFactory.populateDefinitionFromClass` seems to handle `@Position`, but is not actually effective in the end.
This means `ClassDefinitionFactory.populateDefinitionFromClass` is unstable, so I filed a PR to disable non-exec-model for the test https://github.com/apache/incubator-kie-drools/pull/6803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594#discussion_r3531886739
##########
drools-docs/src/modules/ROOT/pages/language-reference/_drl-rules.adoc:
##########
@@ -680,10 +733,8 @@ Person person = new Person( "John", "Doe" );
----
--
-//@comment Currently TBD in Kogito, so excluding for now. (Stetson 7 Apr 2020)
Review Comment:
Everything contained in this previously-commented block is working and covered by unit tests (says claude), I think uncommenting it is appropriate.
Traditional language reference docs left untouched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594#issuecomment-4900318952
@drccrd Thank you for the docs PR. One point: I think it should mention that the use of `@Position` for the generated constructor is specific to exec-model. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Docs 6779 declared type extends java [incubator-kie-docs]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on PR #4594:
URL: https://github.com/apache/incubator-kie-docs/pull/4594#issuecomment-4912981739
@tkobayas thank you for the clarification - I don't see any need to change the legacy model, this was just my misundertstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org