You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/07 23:13:00 UTC
[GitHub] [druid] vogievetsky opened a new pull request, #13050: Web console: fix number of expected functions
vogievetsky opened a new pull request, #13050:
URL: https://github.com/apache/druid/pull/13050
Make the log message not say `undefined` (and rewrite the code so it can not happen again)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a diff in pull request #13050: Web console: fix number of expected functions
Posted by GitBox <gi...@apache.org>.
kfaraz commented on code in PR #13050:
URL: https://github.com/apache/druid/pull/13050#discussion_r965533658
##########
web-console/script/create-sql-docs.js:
##########
@@ -90,15 +90,15 @@ const readDoc = async () => {
// Make sure there are enough functions found
const numFunction = Object.keys(functionDocs).length;
- if (numFunction < MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS) {
+ if (!(MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS <= numFunction)) {
Review Comment:
Is this some weird js quirk? How is this different from the original `numFunc < MIN_EXPECTED` condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #13050: Web console: fix number of expected functions
Posted by GitBox <gi...@apache.org>.
vogievetsky merged PR #13050:
URL: https://github.com/apache/druid/pull/13050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a diff in pull request #13050: Web console: fix number of expected functions
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on code in PR #13050:
URL: https://github.com/apache/druid/pull/13050#discussion_r966196522
##########
web-console/script/create-sql-docs.js:
##########
@@ -90,15 +90,15 @@ const readDoc = async () => {
// Make sure there are enough functions found
const numFunction = Object.keys(functionDocs).length;
- if (numFunction < MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS) {
+ if (!(MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS <= numFunction)) {
Review Comment:
they behave differently if `numFunctions` is `undefined` because all comparisons with undefined are always false:
<img width="145" alt="image" src="https://user-images.githubusercontent.com/177816/189180402-14b543bd-35f2-4cef-aca0-04864660ed29.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org