You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/19 14:13:00 UTC
[GitHub] [superset] geido opened a new pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
geido opened a new pull request #12598:
URL: https://github.com/apache/superset/pull/12598
### SUMMARY
Closes #12488
Makes the table in the modal scrollable while keeping all the other elements sticky.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE Change Dataset Modal:
https://user-images.githubusercontent.com/60598000/105045601-62770d00-5a68-11eb-8091-7aa7a46d7b1a.mp4
AFTER Change Dataset Modal:
https://user-images.githubusercontent.com/60598000/105045646-6d31a200-5a68-11eb-8824-558ce38ae35d.mp4
BEFORE Edit Dataset Modal:
https://user-images.githubusercontent.com/60598000/105045693-7cb0eb00-5a68-11eb-83c2-c640ced94c88.mp4
AFTER Edit Dataset Modal:
https://user-images.githubusercontent.com/60598000/105045718-83d7f900-5a68-11eb-89d2-2bcf70724533.mp4
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #12488
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560390176
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -27,6 +27,8 @@ import './crud.less';
interface CRUDCollectionProps {
allowAddItem?: boolean;
allowDeletes?: boolean;
+ allowSyncFromSource?: boolean;
+ onSyncFromSource?: () => void;
Review comment:
The button "SYNC COLUMNS FROM SOURCE" has been moved inside the `CollectionTable` as it is now showing at the same position as the "ADD ITEM" button. In order for that button to show I need to pass the props down. For reference:
https://github.com/apache/superset/pull/12598/files#diff-e8b4fac0007a1089eef1deba6bb13998971222c5b759246e2b4e9b2dc20632c5R310
https://github.com/apache/superset/pull/12598/files#diff-e8b4fac0007a1089eef1deba6bb13998971222c5b759246e2b4e9b2dc20632c5R323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560443771
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -41,6 +43,7 @@ interface CRUDCollectionProps {
) => ReactNode)[];
onChange?: (arg0: any) => void;
tableColumns: Array<any>;
+ scrollTable?: boolean;
Review comment:
Oh I didn't know that. That's great to know! I'll change it. Thanks a lot @ktmud!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12598:
URL: https://github.com/apache/superset/pull/12598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-763017144
Tested manually across safari,chrome,firefox 🟢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560392887
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -27,6 +27,8 @@ import './crud.less';
interface CRUDCollectionProps {
allowAddItem?: boolean;
allowDeletes?: boolean;
+ allowSyncFromSource?: boolean;
+ onSyncFromSource?: () => void;
Review comment:
I get your point about it being specific to the Datasource only though. Let me check if I can move it out while keeping the same position.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560379179
##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
footer?: React.ReactNode;
wrapProps?: object;
height?: string;
+ scrollTableMode?: boolean;
}
interface StyledModalProps extends SupersetThemeProps {
maxWidth?: string;
responsive?: boolean;
height?: string;
+ scrollTableMode?: boolean;
Review comment:
Do we really need both props for the modal? And I think it's OK to keep some bottom padding when only table body is scrollable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (4c4e3eb) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 63.23% -3.53%
==========================================
Files 1015 486 -529
Lines 49638 29959 -19679
Branches 4839 0 -4839
==========================================
- Hits 33137 18945 -14192
+ Misses 16378 11014 -5364
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.23% <ø> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.24%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...4c4e3eb](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (e5a0594) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `4.10%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 62.65% -4.11%
==========================================
Files 1015 1015
Lines 49638 49643 +5
Branches 4839 4845 +6
==========================================
- Hits 33137 31103 -2034
- Misses 16378 18343 +1965
- Partials 123 197 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.81% <66.66%> (+0.07%)` | :arrow_up: |
| python | `63.85% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `70.56% <ø> (+3.46%)` | :arrow_up: |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.77% <ø> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `67.54% <55.55%> (+4.92%)` | :arrow_up: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `89.09% <100.00%> (+0.20%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.18% <100.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [229 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...e5a0594](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dd2824b) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.18% -3.62%
==========================================
Files 1015 486 -529
Lines 49676 29982 -19694
Branches 4847 0 -4847
==========================================
- Hits 33183 18945 -14238
+ Misses 16371 11037 -5334
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.18% <ø> (-0.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762865573
@junlincc @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dc0f962) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.47% -3.33%
==========================================
Files 1015 486 -529
Lines 49676 29984 -19692
Branches 4847 0 -4847
==========================================
- Hits 33183 19031 -14152
+ Misses 16371 10953 -5418
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | | |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | | |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | | |
| [superset-frontend/src/messageToasts/constants.ts](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29uc3RhbnRzLnRz) | | |
| ... and [512 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dc0f962) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.47% -3.32%
==========================================
Files 1015 486 -529
Lines 49676 29969 -19707
Branches 4847 0 -4847
==========================================
- Hits 33183 19024 -14159
+ Misses 16371 10945 -5426
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.36% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (e5a0594) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `4.55%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 62.20% -4.56%
==========================================
Files 1015 1015
Lines 49638 49628 -10
Branches 4839 4845 +6
==========================================
- Hits 33137 30871 -2266
- Misses 16378 18560 +2182
- Partials 123 197 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.81% <66.66%> (+0.07%)` | :arrow_up: |
| python | `63.11% <ø> (-0.86%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `70.56% <ø> (+3.46%)` | :arrow_up: |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.77% <ø> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `67.54% <55.55%> (+4.92%)` | :arrow_up: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `89.09% <100.00%> (+0.20%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.18% <100.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [256 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...e5a0594](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (e5a0594) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `4.35%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 62.40% -4.36%
==========================================
Files 1015 1015
Lines 49638 49628 -10
Branches 4839 4845 +6
==========================================
- Hits 33137 30969 -2168
- Misses 16378 18462 +2084
- Partials 123 197 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.81% <66.66%> (+0.07%)` | :arrow_up: |
| python | `63.44% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `70.56% <ø> (+3.46%)` | :arrow_up: |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.77% <ø> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `67.54% <55.55%> (+4.92%)` | :arrow_up: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `89.09% <100.00%> (+0.20%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.18% <100.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [242 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...e5a0594](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r562105157
##########
File path: superset-frontend/src/components/TableView/TableView.tsx
##########
@@ -51,7 +52,16 @@ const EmptyWrapper = styled.div`
const TableViewStyles = styled.div<{
isPaginationSticky?: boolean;
+ scrollTable?: boolean;
}>`
+ ${({ scrollTable, theme }) =>
+ scrollTable &&
+ `
+ height: 300px;
Review comment:
That's a good idea. However, there is some calculation to do to make sure the height is just right for the modal to avoid showing its own scrollbar. I'll keep this in mind for an enhancement and provide a separate PR for the sake of getting this improvement in asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12598:
URL: https://github.com/apache/superset/pull/12598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dd2824b) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.68% -3.12%
==========================================
Files 1015 486 -529
Lines 49676 29984 -19692
Branches 4847 0 -4847
==========================================
- Hits 33183 19095 -14088
+ Misses 16371 10889 -5482
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <ø> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.82% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <0.00%> (-1.83%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (e5a0594) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `4.33%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 62.42% -4.34%
==========================================
Files 1015 1015
Lines 49638 49628 -10
Branches 4839 4845 +6
==========================================
- Hits 33137 30980 -2157
- Misses 16378 18451 +2073
- Partials 123 197 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.81% <66.66%> (+0.07%)` | :arrow_up: |
| python | `63.47% <ø> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `70.56% <ø> (+3.46%)` | :arrow_up: |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.77% <ø> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `67.54% <55.55%> (+4.92%)` | :arrow_up: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `89.09% <100.00%> (+0.20%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.18% <100.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [240 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...e5a0594](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560380933
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -27,6 +27,8 @@ import './crud.less';
interface CRUDCollectionProps {
allowAddItem?: boolean;
allowDeletes?: boolean;
+ allowSyncFromSource?: boolean;
+ onSyncFromSource?: () => void;
Review comment:
Both props seem to be `Datasource` table specific and should not be added to the general `CollectionTable` component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (4c4e3eb) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `3.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 63.72% -3.04%
==========================================
Files 1015 486 -529
Lines 49638 29959 -19679
Branches 4839 0 -4839
==========================================
- Hits 33137 19090 -14047
+ Misses 16378 10869 -5509
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.72% <ø> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.33% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [534 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...4c4e3eb](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (e5a0594) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `4.33%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 62.41% -4.34%
==========================================
Files 1015 1015
Lines 49638 49643 +5
Branches 4839 4845 +6
==========================================
- Hits 33137 30987 -2150
- Misses 16378 18459 +2081
- Partials 123 197 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.81% <66.66%> (+0.07%)` | :arrow_up: |
| python | `63.47% <ø> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `70.56% <ø> (+3.46%)` | :arrow_up: |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.77% <ø> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `67.54% <55.55%> (+4.92%)` | :arrow_up: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `89.09% <100.00%> (+0.20%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.18% <100.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [232 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...e5a0594](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560442210
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -41,6 +43,7 @@ interface CRUDCollectionProps {
) => ReactNode)[];
onChange?: (arg0: any) => void;
tableColumns: Array<any>;
+ scrollTable?: boolean;
Review comment:
`stikyHeader` is a pretty popular pattern for large tables and not limited to modals, even within Superset. We've seen it used in SQL Lab results preview, Table viz, and Explore data preview... to name few.
Material UI has a similar API: https://material-ui.com/zh/api/table/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560380093
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -41,6 +43,7 @@ interface CRUDCollectionProps {
) => ReactNode)[];
onChange?: (arg0: any) => void;
tableColumns: Array<any>;
+ scrollTable?: boolean;
Review comment:
nit: maybe name this `stickyHeader`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560384859
##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
footer?: React.ReactNode;
wrapProps?: object;
height?: string;
+ scrollTableMode?: boolean;
}
interface StyledModalProps extends SupersetThemeProps {
maxWidth?: string;
responsive?: boolean;
height?: string;
+ scrollTableMode?: boolean;
Review comment:
You would see the white padding at the bottom overlaying the table and creating a disturbing effect for the eyes. I am happy to change the name or pass it down differently if you have a better idea though @ktmud.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (4c4e3eb) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `2.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 63.84% -2.92%
==========================================
Files 1015 486 -529
Lines 49638 29959 -19679
Branches 4839 0 -4839
==========================================
- Hits 33137 19127 -14010
+ Misses 16378 10832 -5546
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.84% <ø> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.36% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `95.74% <0.00%> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...4c4e3eb](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (e5a0594) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `5.94%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 60.81% -5.95%
==========================================
Files 1015 529 -486
Lines 49638 19659 -29979
Branches 4839 4845 +6
==========================================
- Hits 33137 11956 -21181
+ Misses 16378 7506 -8872
- Partials 123 197 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.81% <66.66%> (+0.07%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `70.56% <ø> (+3.46%)` | :arrow_up: |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.77% <ø> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `67.54% <55.55%> (+4.92%)` | :arrow_up: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `89.09% <100.00%> (+0.20%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.18% <100.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [709 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...e5a0594](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560384859
##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
footer?: React.ReactNode;
wrapProps?: object;
height?: string;
+ scrollTableMode?: boolean;
}
interface StyledModalProps extends SupersetThemeProps {
maxWidth?: string;
responsive?: boolean;
height?: string;
+ scrollTableMode?: boolean;
Review comment:
You would see the white padding at the bottom overlaying the table and creating a disturbing effect for the eyes. I am happy to change the name or pass it down differently if you have a better idea though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r562060939
##########
File path: superset-frontend/src/components/TableView/TableView.tsx
##########
@@ -51,7 +52,16 @@ const EmptyWrapper = styled.div`
const TableViewStyles = styled.div<{
isPaginationSticky?: boolean;
+ scrollTable?: boolean;
}>`
+ ${({ scrollTable, theme }) =>
+ scrollTable &&
+ `
+ height: 300px;
Review comment:
Should we make this height configurable, or use something like `40vh` (40% of viewport height)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (4c4e3eb) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `2.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 63.81% -2.95%
==========================================
Files 1015 486 -529
Lines 49638 29959 -19679
Branches 4839 0 -4839
==========================================
- Hits 33137 19117 -14020
+ Misses 16378 10842 -5536
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.81% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.85% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.36% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [527 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...4c4e3eb](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560390176
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -27,6 +27,8 @@ import './crud.less';
interface CRUDCollectionProps {
allowAddItem?: boolean;
allowDeletes?: boolean;
+ allowSyncFromSource?: boolean;
+ onSyncFromSource?: () => void;
Review comment:
The button "SYNC COLUMNS FROM SOURCE" has been moved inside the `CollectionTable` as it now showing at the same position as the "ADD ITEM" button. In order for that button to show I need to pass the props down. For references:
https://github.com/apache/superset/pull/12598/files#diff-e8b4fac0007a1089eef1deba6bb13998971222c5b759246e2b4e9b2dc20632c5R310
https://github.com/apache/superset/pull/12598/files#diff-e8b4fac0007a1089eef1deba6bb13998971222c5b759246e2b4e9b2dc20632c5R323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560453665
##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
footer?: React.ReactNode;
wrapProps?: object;
height?: string;
+ scrollTableMode?: boolean;
}
interface StyledModalProps extends SupersetThemeProps {
maxWidth?: string;
responsive?: boolean;
height?: string;
+ scrollTableMode?: boolean;
Review comment:
You could add a `margin-bottom: - theme.gridUnit * 4` to the scrollable table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r562105157
##########
File path: superset-frontend/src/components/TableView/TableView.tsx
##########
@@ -51,7 +52,16 @@ const EmptyWrapper = styled.div`
const TableViewStyles = styled.div<{
isPaginationSticky?: boolean;
+ scrollTable?: boolean;
}>`
+ ${({ scrollTable, theme }) =>
+ scrollTable &&
+ `
+ height: 300px;
Review comment:
That's a good idea. However, there is some calculation to do to make sure the height is just right for the modal to avoid showing its own scrollbar. I'll keep this in mind for an enhancement and provide a separate PR for the sake of getting this improvement in asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dd2824b) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.18% -3.62%
==========================================
Files 1015 486 -529
Lines 49676 29982 -19694
Branches 4847 0 -4847
==========================================
- Hits 33183 18945 -14238
+ Misses 16371 11037 -5334
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.18% <ø> (-0.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dd2824b) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.68% -3.12%
==========================================
Files 1015 486 -529
Lines 49676 29984 -19692
Branches 4847 0 -4847
==========================================
- Hits 33183 19095 -14088
+ Misses 16371 10889 -5482
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <ø> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.82% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <0.00%> (-1.83%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560386960
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -41,6 +43,7 @@ interface CRUDCollectionProps {
) => ReactNode)[];
onChange?: (arg0: any) => void;
tableColumns: Array<any>;
+ scrollTable?: boolean;
Review comment:
This is a behaviour that is specific to modals using tables. I am worried that `stickyHeader` might not convey the actual functionality. Something on the line `tableMode` or `scrollableTableMode`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560386960
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -41,6 +43,7 @@ interface CRUDCollectionProps {
) => ReactNode)[];
onChange?: (arg0: any) => void;
tableColumns: Array<any>;
+ scrollTable?: boolean;
Review comment:
This is a behaviour that is specific to modals using tables. I am worried that `stickyHeader` might not convey the actual functionality. Something on the line `tableMode` or `scrollableTableMode`? What do you think @ktmud ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r562060939
##########
File path: superset-frontend/src/components/TableView/TableView.tsx
##########
@@ -51,7 +52,16 @@ const EmptyWrapper = styled.div`
const TableViewStyles = styled.div<{
isPaginationSticky?: boolean;
+ scrollTable?: boolean;
}>`
+ ${({ scrollTable, theme }) =>
+ scrollTable &&
+ `
+ height: 300px;
Review comment:
Should we make this height configurable, or use something like `40vh` (40% of viewport height)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dc0f962) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.44% -3.36%
==========================================
Files 1015 486 -529
Lines 49676 29969 -19707
Branches 4847 0 -4847
==========================================
- Hits 33183 19014 -14169
+ Misses 16371 10955 -5416
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.44% <ø> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.45% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (dc0f962) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.79% 63.38% -3.42%
==========================================
Files 1015 486 -529
Lines 49676 29969 -19707
Branches 4847 0 -4847
==========================================
- Hits 33183 18997 -14186
+ Misses 16371 10972 -5399
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.65% <0.00%> (-0.93%)` | :arrow_down: |
| ... and [527 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [2463215...dd2824b](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560386960
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -41,6 +43,7 @@ interface CRUDCollectionProps {
) => ReactNode)[];
onChange?: (arg0: any) => void;
tableColumns: Array<any>;
+ scrollTable?: boolean;
Review comment:
This is a behaviour that is specific to modals using tables. I am worried that `stickyHeader` might not convey the actual functionality. Something on the line `tableMode` or `stickyTableMode`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12598:
URL: https://github.com/apache/superset/pull/12598#issuecomment-762895518
# [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=h1) Report
> Merging [#12598](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=desc) (b8a8034) into [master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc) (e7a5d0d) will **decrease** coverage by `3.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12598 +/- ##
==========================================
- Coverage 66.75% 63.17% -3.59%
==========================================
Files 1015 486 -529
Lines 49638 29972 -19666
Branches 4839 0 -4839
==========================================
- Hits 33137 18935 -14202
+ Misses 16378 11037 -5341
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.17% <ø> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [534 more](https://codecov.io/gh/apache/superset/pull/12598/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=footer). Last update [e7a5d0d...b8a8034](https://codecov.io/gh/apache/superset/pull/12598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560379179
##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
footer?: React.ReactNode;
wrapProps?: object;
height?: string;
+ scrollTableMode?: boolean;
}
interface StyledModalProps extends SupersetThemeProps {
maxWidth?: string;
responsive?: boolean;
height?: string;
+ scrollTableMode?: boolean;
Review comment:
Do we really need both props for the modal? I think it's OK to keep some bottom padding when only table body is scrollable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org