You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/06/06 00:08:46 UTC
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/
-----------------------------------------------------------
(Updated June 5, 2018, 5:08 p.m.)
Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
Changes
-------
Updated test cases.
Summary (updated)
-----------------
Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.
Bugs: MESOS-8830
https://issues.apache.org/jira/browse/MESOS-8830
Repository: mesos
Description (updated)
-------
The current `ROOT_BusyMountPoint` test would fail because we added
support for unmounting dangling mount points in directory to gc. This
patch rewrote this test to reflect that after unmounting, the gc
succeeded, directory was gone and metrics were correctly reported.
Diffs (updated)
-----
src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
Diff: https://reviews.apache.org/r/67421/diff/3/
Changes: https://reviews.apache.org/r/67421/diff/2-3/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204627
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/gc_tests.cpp
Lines 912 (patched)
<https://reviews.apache.org/r/67421/#comment287212>
Can you use `DEFAULT_TEST_ROLE` here?
```
flags.resources = strings::format(
"disk(%s):1024",
DEFAULT_TEST_ROLE).get();
```
- Jie Yu
On June 6, 2018, 12:08 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 12:08 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
>
>
> Diff: https://reviews.apache.org/r/67421/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/
-----------------------------------------------------------
(Updated June 12, 2018, 1:23 p.m.)
Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
Bugs: MESOS-8830
https://issues.apache.org/jira/browse/MESOS-8830
Repository: mesos
Description
-------
The current `ROOT_BusyMountPoint` test would fail because we added
support for unmounting dangling mount points in directory to gc. This
patch rewrote this test to reflect that after unmounting, the gc
succeeded, directory was gone and metrics were correctly reported.
Diffs (updated)
-----
src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
Diff: https://reviews.apache.org/r/67421/diff/5/
Changes: https://reviews.apache.org/r/67421/diff/4-5/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204406
-----------------------------------------------------------
PASS: Mesos patch 67421 was successfully built and tested.
Reviews applied: `['67264', '67423', '67421']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67421
- Mesos Reviewbot Windows
On June 5, 2018, 5:08 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 5:08 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
>
>
> Diff: https://reviews.apache.org/r/67421/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204440
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67264, 67423, 67421]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 5, 2018, 5:08 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 5:08 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
>
>
> Diff: https://reviews.apache.org/r/67421/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204382
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67264, 67423, 67421]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 6, 2018, 12:08 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 12:08 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
>
>
> Diff: https://reviews.apache.org/r/67421/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to
reflect updated behavior.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204357
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67264', '67423', '67421']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67421
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67421/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (118 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1074 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1024 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (1050 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1388 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (1414 ms total)
[----------] Global test environment tear-down
[==========] 988 tests from 97 test cases ran. (514230 ms total)
[ PASSED ] 987 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.SigkillExecutor/0, where GetParam() = "docker,mesos"
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67421/logs/mesos-tests-stderr.log):
```
I0606 02:31:03.230854 12092 master.cpp:10863] Updating the state of task 8a364875-ed01-4861-bb2a-f76b4ebdab49 of framework a144ace1-b9d0-40be-91ef-86e63e22b19f-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0606 02:31:03.230854 15436 slave.cpp:3939] Shutting down framework a144ace1-b9d0-40be-91ef-86e63e22b19f-0000
I0606 02:31:03.230854 15436 slave.cpp:6660] Shutting down executor '8a364875-ed01-4861-bb2a-f76b4ebdab49' of framework a144ace1-b9d0-40be-91ef-86e63e22b19f-0000 at executor(1)@192.10.1.5:54146
I0606 02:31:03.232861 15436 slave.cpp:931] Agent terminating
W0606 02:31:03.232861 15436 slave.cpp:3935] Ignoring shutdown framework a144ace1-b9d0-40be-91ef-86e63e22b19f-0000 because it is terminating
I0606 02:31:03.233860 12092 master.cpp:10962] Removing task 8a364875-ed01-4861-bb2a-f76b4ebdab49 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of frameworI0606 02:31:02.730846 2992 exec.cpp:162] Version: 1.7.0
I0606 02:31:02.757848 18392 exec.cpp:236] Executor registered on agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0
I0606 02:31:02.762850 18164 executor.cpp:178] Received SUBSCRIBED event
I0606 02:31:02.767850 18164 executor.cpp:182] Subscribed executor on windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0606 02:31:02.770851 18164 executor.cpp:178] Received LAUNCH event
I0606 02:31:02.776850 18164 executor.cpp:665] Starting task 8a364875-ed01-4861-bb2a-f76b4ebdab49
I0606 02:31:02.869858 18164 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0606 02:31:03.196879 18164 executor.cpp:678] Forked command at 2232
I0606 02:31:03.232861 19992 exec.cpp:445] Executor asked to shutdown
I0606 02:31:03.233860 18776 executor.cpp:178] Received SHUTDOWN event
I0606 02:31:03.233860 18776 executor.cpp:781] Shutting down
I0606 02:31:03.233860 18776 executor.cpp:894] Sending SIGTERM to process tree at pid 223k a144ace1-b9d0-40be-91ef-86e63e22b19f-0000 on agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0 at slave(449)@192.10.1.5:54125 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0606 02:31:03.237862 12092 master.cpp:1293] Agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0 at slave(449)@192.10.1.5:54125 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0606 02:31:03.238848 12092 master.cpp:3303] Disconnecting agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0 at slave(449)@192.10.1.5:54125 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0606 02:31:03.238848 12092 master.cpp:3322] Deactivating agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0 at slave(449)@192.10.1.5:54125 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0606 02:31:03.238848 12820 hierarchical.cpp:344] Removed framework a144ace1-b9d0-40be-91ef-86e63e22b19f-0000
I0606 02:31:03.238848 12820 hierarchical.cpp:766] Agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0 deactivated
I0606 02:31:03.238848 17488 containerizer.cpp:2405] Destroying container 3ac56856-8189-443e-b0db-2cfbc4cbffd3 in RUNNING state
I0606 02:31:03.239881 17488 containerizer.cpp:3019] Transitioning the state of container 3ac56856-8189-443e-b0db-2cfbc4cbffd3 from RUNNING to DESTROYING
I0606 02:31:03.241188 17488 launcher.cpp:155] Asked to destroy container 3ac56856-8189-443e-b0db-2cfbc4cbffd3
I0606 02:31:03.273880 20992 containerizer.cpp:2858] Container 3ac56856-8189-443e-b0db-2cfbc4cbffd3 has exited
I0606 02:31:03.305858 16600 master.cpp:1135] Master terminating
I0606 02:31:03.308883 14316 hierarchical.cpp:609] Removed agent a144ace1-b9d0-40be-91ef-86e63e22b19f-S0
I0606 02:31:03.787909 6632 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On June 5, 2018, 5:08 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 5:08 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
>
>
> Diff: https://reviews.apache.org/r/67421/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>