You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/01 20:16:23 UTC

[GitHub] [airflow] ryanahamilton commented on a change in pull request #20730: Webserver - Change URL routes for DAG page and rename "tree" to "grid"

ryanahamilton commented on a change in pull request #20730:
URL: https://github.com/apache/airflow/pull/20730#discussion_r796972181



##########
File path: airflow/www/views.py
##########
@@ -2788,11 +2895,22 @@ def tries(self, session=None):
         ]
     )
     @action_logging
+    def legacy_landing_times(self):
+        """Redirect from url param."""
+        return redirect(url_for('Airflow.landing_times', **request.args))
+
+    @expose('/dags/<string:dag_id>/landing_times')

Review comment:
       While we're changing this, could we use a hyphen instead? Hyphens are a more common, modern practice and we've used them in recent additions (e.g. `/rendered-k8s`, `/rendered-templates`).
   ```suggestion
       @expose('/dags/<string:dag_id>/landing-times')
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org