[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #510: Ftr : add UnRegister and UnSubscribe for zookeeper Registry

[GitBox <gi...@apache.org>]

fangyincheng commented on a change in pull request #510:
URL: https://github.com/apache/dubbo-go/pull/510#discussion_r426289413



##########
File path: registry/zookeeper/registry_test.go
##########
@@ -74,6 +99,39 @@ func Test_Subscribe(t *testing.T) {
 	defer ts.Stop()
 }
 
+func Test_NoSubscribe(t *testing.T) {
+	regurl, _ := common.NewURL("registry://127.0.0.1:1111", common.WithParamsValue(constant.ROLE_KEY, strconv.Itoa(common.PROVIDER)))
+	url, _ := common.NewURL("dubbo://127.0.0.1:20000/com.ikurento.user.UserProvider", common.WithParamsValue(constant.CLUSTER_KEY, "mock"), common.WithMethods([]string{"GetUser", "AddUser"}))
+	ts, reg, _ := newMockZkRegistry(&regurl)
+
+	//provider register
+	err := reg.Register(url)
+	assert.NoError(t, err)
+
+	if err != nil {

Review comment:
       why add err != nil? by `assert.NoError(t, err)`, when err != nil, the ut will fail.

##########
File path: registry/mock_registry.go
##########
@@ -51,6 +51,12 @@ func (*MockRegistry) Register(url common.URL) error {
 	return nil
 }
 
+// UnRegister
+func (r *MockRegistry) UnRegister(conf common.URL) error {
+
+	return nil

Review comment:
       del empty line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org