You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "manstis (via GitHub)" <gi...@apache.org> on 2023/03/03 10:07:00 UTC
[GitHub] [camel-k] manstis opened a new pull request, #4097: [camel-kamelets] Issue-1330: Deprecating parameters
manstis opened a new pull request, #4097:
URL: https://github.com/apache/camel-k/pull/4097
<!-- Description -->
https://github.com/apache/camel-kamelets/issues/1330
I added the CRD field as [instructed](https://github.com/apache/camel-kamelets/issues/1330#issuecomment-1452254413) and similar to the `JSONSchemaProp` structure.
I checked generating the documentation with `deprecated` property and it is already handled.
Just the validation fails as the CRD schema lacks the property.
There is a generated [file](https://github.com/apache/camel-k/blob/main/pkg/apis/camel/v1alpha1/zz_generated.deepcopy.go#L246) that looks as though it should be re-generated (since it handles the `JSONSchemaProp` structure) however I could not see how to regenerate it. The code comments in other [files](https://github.com/apache/camel-k/blob/main/pkg/apis/camel/v1/build_types.go#L26) suggest a `make` step for `generate-deepcopy` but that appears to be long gone following refactoring of the repository over the years.
Advice is welcome.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#issuecomment-1453344501
I dont know if it makes sense to bring this down on 1.12.x too, it should be harmless but it's a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] manstis commented on pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#issuecomment-1453345842
> I dont know if it makes sense to bring this down on 1.12.x too, it should be harmless but it's a breaking change.
Let me know.. it's your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] manstis commented on pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#issuecomment-1453372642
@squakez Do you mean [`release-1.12.x`](https://github.com/apache/camel-k/tree/release-1.12.x)?
I couldn't see a `1.12.x` otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#issuecomment-1453367248
> I dont know if it makes sense to bring this down on 1.12.x too, it should be harmless but it's a breaking change.
I don't think it's a breaking change as we introduce a parameter which could be optional. Whatever works now in 1.12 will work after the change. Feel free to backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#discussion_r1124276634
##########
config/crd/bases/camel.apache.org_builds.yaml:
##########
@@ -19,7 +19,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.6.1
+ controller-gen.kubebuilder.io/version: v0.9.2
Review Comment:
This does not look good. I think you have some controller-gen version in your local environment different than the one we are using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#issuecomment-1453388316
yes, it's release-1.12.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] manstis commented on a diff in pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on code in PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#discussion_r1124298618
##########
config/crd/bases/camel.apache.org_builds.yaml:
##########
@@ -19,7 +19,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.6.1
+ controller-gen.kubebuilder.io/version: v0.9.2
Review Comment:
I did wonder.. fixed (I regenerated with `controller-gen@v0.6.1`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] manstis commented on a diff in pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on code in PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#discussion_r1124298618
##########
config/crd/bases/camel.apache.org_builds.yaml:
##########
@@ -19,7 +19,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.6.1
+ controller-gen.kubebuilder.io/version: v0.9.2
Review Comment:
I did wonder.. fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4097:
URL: https://github.com/apache/camel-k/pull/4097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] manstis commented on pull request #4097: [camel-kamelets] Issue-1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on PR #4097:
URL: https://github.com/apache/camel-k/pull/4097#issuecomment-1453302648
Thanks @squakez @oscerd.
IDK the CRDs were generated from the sources.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org