[jira] [Resolved] (SUBMARINE-79) Cleanup MockRemoteDirectoryManager

["Liu Xun (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SUBMARINE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Liu Xun resolved SUBMARINE-79.
------------------------------
    Fix Version/s: 0.4.0
       Resolution: Fixed

Issue resolved by pull request 223
[https://github.com/apache/submarine/pull/223]

> Cleanup MockRemoteDirectoryManager
> ----------------------------------
>
>                 Key: SUBMARINE-79
>                 URL: https://issues.apache.org/jira/browse/SUBMARINE-79
>             Project: Apache Submarine
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Szilard Nemeth
>            Assignee: Neo Chien
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.4.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Many methods in MockRemoteDirectoryManager are declaring unnecessary throws clause for IOException.
> Also, there are 2 dangerous NPE candidates: 
> 1. MockRemoteDirectoryManager#getJobStagingArea: 
> {code:java}
> this.jobDir = new File(jobsParentDir.getAbsolutePath(), jobName);
> {code}
> If jobsParentDir is null, we could have an NPE easily.
> 2. MockRemoteDirectoryManager#getModelDir: 
> {code:java}
> File modelDir = new File(modelParentDir.getAbsolutePath(), modelName);
> {code}
> If modelParentDir is null, we could have an NPE easily.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org