You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/16 08:41:07 UTC

[GitHub] [spark] peter-toth commented on a change in pull request #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

peter-toth commented on a change in pull request #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec
URL: https://github.com/apache/spark/pull/28083#discussion_r409383358
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
 ##########
 @@ -143,10 +143,7 @@ trait Block extends TreeNode[Block] with JavaCode {
     case _ => code.trim
   }
 
-  def length: Int = {
-    // Returns a code length without comments
 
 Review comment:
   Ok, added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org