You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bcel-dev@jakarta.apache.org by bu...@apache.org on 2007/03/08 23:55:46 UTC
DO NOT REPLY [Bug 41794] New: - Maven POM file calls in apache regex but code does not use it
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41794>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41794
Summary: Maven POM file calls in apache regex but code does not
use it
Product: BCEL
Version: unspecified
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Main
AssignedTo: bcel-dev@jakarta.apache.org
ReportedBy: ian988@darwinsys.com
Seems the code was modernized to use java.util.regex but the Maven POM file was
not updated at the time.
A simple SVN patch is here:
Index: /home/ian/workspace/bcel/pom.xml
===================================================================
--- /home/ian/workspace/bcel/pom.xml (revision 516101)
+++ /home/ian/workspace/bcel/pom.xml (working copy)
@@ -170,11 +170,6 @@
<dependencies>
<dependency>
- <groupId>jakarta-regexp</groupId>
- <artifactId>jakarta-regexp</artifactId>
- <version>1.4</version>
- </dependency>
- <dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>3.8.1</version>
Given that the only external dependency is now junit3.8 which *everybody* has a
copy of, one could switch from Maven to Ant and avoid the dependency on Maven,
but that's rather a different story :-)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 41794] - Maven POM file calls in apache regex but code does not use it
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41794>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41794
tcurdt@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From tcurdt@apache.org 2007-03-10 06:48 -------
Thanks, applied. Please next time attach the patches.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 41794] - Maven POM file calls in apache regex but code does not use it
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41794>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41794
------- Additional Comments From ian988@darwinsys.com 2007-03-08 15:09 -------
Err, whomever commits that should also commit this repair of the
relevant comment in o.a.b.util.InstructionFinder:
Index:
/home/ian/workspace/bcel/src/main/java/org/apache/bcel/util/InstructionFinder.java
===================================================================
---
/home/ian/workspace/bcel/src/main/java/org/apache/bcel/util/InstructionFinder.java
(revision 516101)
+++
/home/ian/workspace/bcel/src/main/java/org/apache/bcel/util/InstructionFinder.java
(working copy)
@@ -1,7 +1,7 @@
/*
* Copyright 2000-2004 The Apache Software Foundation
*
- * Licensed under the Apache License, Version 2.0 (the "License");
+ * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
@@ -11,7 +11,7 @@
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations under the License.
*
*/
package org.apache.bcel.util;
@@ -36,19 +36,19 @@
* expressions. This can be used, e.g., in order to implement a peep hole
* optimizer that looks for code patterns and replaces them with faster
* equivalents.
- *
+ *
* <p>
- * This class internally uses the <a href="http://jakarta.apache.org/regexp/">
- * Regexp</a> package to search for regular expressions.
- *
+ * This class internally uses the java.util.regex
+ * package to search for regular expressions.
+ *
* A typical application would look like this:
- *
+ *
* <pre>
- *
- *
+ *
+ *
* InstructionFinder f = new InstructionFinder(il);
* String pat = "IfInstruction ICONST_0 GOTO ICONST_1 NOP
(IFEQ|IFNE)";
- *
+ *
* for(Iterator i = f.search(pat, constraint); i.hasNext(); ) {
* InstructionHandle[] match = (InstructionHandle[])i.next();
* ...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org