You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/08/27 22:58:55 UTC

[GitHub] [sling-org-apache-sling-scripting-sightly-models-provider] paul-bjorkstrand commented on pull request #1: Allow an adaptable argument

paul-bjorkstrand commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-models-provider/pull/1#issuecomment-682232542


   @raducotescu, @vladbailescu, and @kwin:
   
   Quite a long time since I revisited this. I have attempted to make some changes to the tests as mentioned by Vlad, but I am not certain exactly how to run the tests. I have pushed my changes to my fork ([commit][1]). If one of you can guide me on how to execute the tests (and review the changes when that PR is opened) then I think we can get this change, and the associated test, merged in.
   
   [1]: https://github.com/paul-bjorkstrand/sling-org-apache-sling-scripting-sightly-testing-content/commit/2fd6a2902b270446070e4833865616df945639f7


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org