You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/31 06:15:58 UTC
[GitHub] [incubator-doris] Vikasss7663 opened a new pull request, #9878: remove redundant this
Vikasss7663 opened a new pull request, #9878:
URL: https://github.com/apache/incubator-doris/pull/9878
Proposed changes
Removing redundant this, since it is required mostly in constructor.
Issue Number: #9775
Problem Summary:
Before pr:
public AlterHandler getSchemaChangeHandler() {
return this.schemaChangeHandler;
}
After pr:
public AlterHandler getSchemaChangeHandler() {
return schemaChangeHandler;
}
Checklist(Required)
Does it affect the original behavior: No
Has unit tests been added: No
Has document been added or modified: No Need
Does it need to update dependencies: No
Are there any changes that cannot be rolled back: No
Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878#issuecomment-1141714578
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878#issuecomment-1148610555
Hi @jackwener
This is to thank you, I have successfully done my first open source contribution, the way you help me means a lot.
The thing I have did, I swear I could do 2 years ago as well but I was scared of open source contribution and it takes almost 2 years for that first contribution because of my fear, but now I think I should give it a try at-least.
Again Thank you ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878#issuecomment-1141714893
cc @yiguolei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee merged pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
HappenLee merged PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878#issuecomment-1146557684
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878#issuecomment-1143831645
what happened @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9878: remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9878:
URL: https://github.com/apache/incubator-doris/pull/9878#issuecomment-1143888500
cc @hf200012 ,PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org