[GitHub] [spark] xinrong-databricks commented on a change in pull request #35533: [WIP] Complete input validation of function to_binary

[GitBox <gi...@apache.org>]

xinrong-databricks commented on a change in pull request #35533:
URL: https://github.com/apache/spark/pull/35533#discussion_r806807720



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2565,15 +2565,15 @@ case class ToBinary(expr: Expression, format: Option[Expression], child: Express
       case lit if lit.foldable =>
         val value = lit.eval()
         if (value == null) Literal(null, BinaryType)
-        else {
+        else if (value.isInstanceOf[UTF8String]) {

Review comment:
       Is it possible for `value` to be an instance of `java.lang.String`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org