You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2020/11/08 16:17:14 UTC

[isis-app-helloworld] 02/02: comments out docker build

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis-app-helloworld.git

commit 9d700363f8cc56bfd8da5322b5fa586653112b75
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Sun Nov 8 16:17:02 2020 +0000

    comments out docker build
---
 .github/workflows/mavenJdk8.yml | 9 ++++-----
 pom.xml                         | 7 ++++++-
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/mavenJdk8.yml b/.github/workflows/mavenJdk8.yml
index 5fd4a63..5937317 100644
--- a/.github/workflows/mavenJdk8.yml
+++ b/.github/workflows/mavenJdk8.yml
@@ -54,9 +54,8 @@ jobs:
       shell: bash
       run: |
         mvn install
-        mvn -Ddocker jib:build
 
-    - name: Build and Push Docker Image
-      shell: bash
-      run: |
-        mvn -Ddocker jib:build
+#    - name: Build and Push Docker Image
+#      shell: bash
+#      run: |
+#        mvn -Ddocker jib:build
diff --git a/pom.xml b/pom.xml
index f1c505c..f776755 100644
--- a/pom.xml
+++ b/pom.xml
@@ -108,11 +108,16 @@
 								<workingDirectory>/run/secrets</workingDirectory>
 							</container>
 							<to>
-								<image>docker.io/apacheisis/helloworld:${env.REVISION}</image>
+								<image>docker.io/apacheisis/helloworld:latest</image>
+<!--
+will use default credentials, eg in ~/.docker/config.json.
+Uncomment to override.
+
 								<auth>
 									<username>${env.DOCKER_REGISTRY_USERNAME}</username>
 									<password>${env.DOCKER_REGISTRY_PASSWORD}</password>
 								</auth>
+-->
 							</to>
 						</configuration>
 						<executions>