[jira] [Commented] (PARQUET-1319) [C++] Pass BISON_EXECUTABLE to Thrift EP for MacOS

["Uwe L. Korn (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506303#comment-16506303 ] 

Uwe L. Korn commented on PARQUET-1319:
--------------------------------------

[~thamha] That should like a reasonable approach. {{THRIFT_CMAKE_ARGS}} should then include {{BISON_EXECUTABLE}} if it is defined, otherwise not. Can you make a PR for this?

> [C++] Pass BISON_EXECUTABLE to Thrift EP for MacOS
> --------------------------------------------------
>
>                 Key: PARQUET-1319
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1319
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-thrift
>         Environment: Mac mini (High Sierra 10.13.4)
>            Reporter: Tham Ha Thi
>            Priority: Major
>             Fix For: cpp-1.5.0
>
>
> I was building parquet-cpp on my Mac mini (High Sierra 10.13.4). I've got an error:
> {code:java}
> /Users/sdkteam/jenkins/workspace/Dev-Mac/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5: invalid directive: `%code'
> /Users/sdkteam/jenkins/workspace/Dev-Mac/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14: syntax error, unexpected identifier
> make[5]: *** [compiler/cpp/thrift/thrifty.cc] Error 1
> make[4]: *** [compiler/cpp/CMakeFiles/parse.dir/all] Error 2
> make[3]: *** [all] Error 2
> {code}
> I googled and they said that I need to upgrade bison to 3.0. I did and did every way I can to config $PATH and successfully change: on terminal "bison --version" printed 3.0.5
> Somehow cmake still recognize old bison in /usr/bin/bison.
> I tried to add BISON_EXECUTABLE=/usr/local/Cellar/bison/3.0.5/bin/bison into THRIFT_CMAKE_ARGS in /cmake_modules/ThirdpartyToolchain.cmake  and it works.
> I think it should be helpful if I can pass BISON_EXECUTABLE from parquet-cpp to thrift ep. Can you please help that or suggest me another way?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)