You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/04/21 09:28:47 UTC

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #149: Add disabled mem control & improve memory efficiency

jt2594838 commented on a change in pull request #149: Add disabled mem control & improve memory efficiency
URL: https://github.com/apache/incubator-iotdb/pull/149#discussion_r277160724
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/engine/bufferwrite/BufferWriteProcessor.java
 ##########
 @@ -454,38 +485,6 @@ public long getFileSize() {
     return file.length() + memoryUsage();
   }
 
-  /**
-   * Close current TsFile and open a new one for future writes. Block new writes and wait until
-   * current writes finish.
-   */
-  public void rollToNewFile() {
-    // TODO : [MemControl] implement this
-  }
-
-  /**
-   * Check if this TsFile has too big metadata or file. If true, close current file and open a new
-   * one.
-   */
-  private boolean checkSize() {
 
 Review comment:
   This is done in another place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services