You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/15 16:22:13 UTC
[GitHub] [kafka] cmccabe commented on a change in pull request #11320: MINOR: Make ReplicaManager, LogManager, KafkaApis easier to construct
cmccabe commented on a change in pull request #11320:
URL: https://github.com/apache/kafka/pull/11320#discussion_r709348152
##########
File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala
##########
@@ -75,13 +75,25 @@ class LogLoaderTest {
// Create a LogManager with some overridden methods to facilitate interception of clean shutdown
// flag and to inject a runtime error
- def interceptedLogManager(logConfig: LogConfig, logDirs: Seq[File], simulateError: SimulateError): LogManager = {
- new LogManager(logDirs = logDirs.map(_.getAbsoluteFile), initialOfflineDirs = Array.empty[File], new MockConfigRepository(),
- initialDefaultConfig = logConfig, cleanerConfig = CleanerConfig(enableCleaner = false), recoveryThreadsPerDataDir = 4,
- flushCheckMs = 1000L, flushRecoveryOffsetCheckpointMs = 10000L, flushStartOffsetCheckpointMs = 10000L,
- retentionCheckMs = 1000L, maxPidExpirationMs = 60 * 60 * 1000, scheduler = time.scheduler, time = time,
- brokerTopicStats = new BrokerTopicStats, logDirFailureChannel = new LogDirFailureChannel(logDirs.size),
- keepPartitionMetadataFile = config.usesTopicId, interBrokerProtocolVersion = config.interBrokerProtocolVersion) {
+ def interceptedLogManager(logConfig: LogConfig, logDirs: Seq[File], simulateError: SimulateError): LogManager =
+ new LogManager(
+ logDirs = logDirs.map(_.getAbsoluteFile),
+ initialOfflineDirs = Array.empty[File],
+ configRepository = new MockConfigRepository(),
+ initialDefaultConfig = logConfig,
+ cleanerConfig = CleanerConfig(enableCleaner = false),
+ recoveryThreadsPerDataDir = 4,
+ flushCheckMs = 1000L,
+ flushRecoveryOffsetCheckpointMs = 10000L,
+ flushStartOffsetCheckpointMs = 10000L,
+ retentionCheckMs = 1000L,
+ maxPidExpirationMs = 60 * 60 * 1000,
+ interBrokerProtocolVersion = config.interBrokerProtocolVersion,
+ scheduler = time.scheduler,
+ brokerTopicStats = new BrokerTopicStats,
Review comment:
I'll add parens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org