You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2005/05/07 20:16:14 UTC

Python testsuite problem

I'm getting lots of failures on trunk, the following is typical:

$ ~/sw/subversion/svn/subversion/tests/clients/cmdline/basic_tests.py --cleanup 1
/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py:159: SyntaxWarning: local name 'message' in 'run_and_verify_svn' shadows use of 'message' as global in nested scope 'handle_output'
  def run_and_verify_svn(message, expected_stdout, expected_stderr, *varargs):
UNEXPECTED EXCEPTION:
Traceback (most recent call last):
  File "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/testcase.py", line 105, in run
    rc = apply(self.pred.func, args)
  File "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/basic_tests.py", line 76, in basic_checkout
    svntest.actions.run_and_verify_svn(None, None, [], 'rm', G_path)
  File "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py", line 185, in run_and_verify_svn
    handle_output(expected_stderr, err, 'stderr', SVNExpectedStderr)
  File "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py", line 174, in handle_output
    compare_and_display_lines(message, output_type.upper(), expected, actual)
NameError: global name 'message' is not defined
FAIL:  basic_tests.py 1: basic checkout of a wc

I'm using:

$ python -V
Python 2.1.3

If I google I one of the first hits is me complaining about r7351!  As
far as I can tell this use of nested functions requires a more recent
Python, the testsuite is supposed to work with 2.1.3 isn't it?

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Python testsuite problem

Posted by David Summers <da...@summersoft.fay.ar.us>.
On Mon, 9 May 2005, Jani Averbach wrote:

> On 2005-05-08 15:04+0100, Max Bowsher wrote:
>>
>> I suppose, if we are serious about python 2.0 compat, we ought to see if
>> any of the people running svn-breakage systems would be willing to arrange
>> for the tests to run with an old python.
>
> I am running svntest suite inside chroot, so I could do almost
> anything with it. I can install python 2.0, but I would not like to do
> it without actual need, because it will require some tweaking (there
> have to be also python 2.2 installed). So, are we serious about python
> 2.0 compat? =)
>

I guess it just depends on what you want to support.  RedHat 7.3 has python-2.2
so as long as that works I'm happy.

--
David Wayne Summers        "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint =  0B44 B118 85CC F4EC 7021  1ED4 1516 5B78 E320 2001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Python testsuite problem

Posted by Jani Averbach <ja...@jaa.iki.fi>.
On 2005-05-08 15:04+0100, Max Bowsher wrote:
> 
> I suppose, if we are serious about python 2.0 compat, we ought to see if 
> any of the people running svn-breakage systems would be willing to arrange 
> for the tests to run with an old python.

I am running svntest suite inside chroot, so I could do almost
anything with it. I can install python 2.0, but I would not like to do
it without actual need, because it will require some tweaking (there
have to be also python 2.2 installed). So, are we serious about python
2.0 compat? =)

BR, Jani

-- 
Jani Averbach

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Python testsuite problem

Posted by Max Bowsher <ma...@ukf.net>.
Philip Martin wrote:
> I'm getting lots of failures on trunk, the following is typical:
>
> $ ~/sw/subversion/svn/subversion/tests/clients/cmdline/basic_tests.py
> --cleanup 1
> 
> /home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py:159:
> SyntaxWarning: local name 'message' in 'run_and_verify_svn' shadows use of
> 'message' as global in nested scope 'handle_output' def
> run_and_verify_svn(message, expected_stdout, expected_stderr, *varargs):
> UNEXPECTED EXCEPTION:
> Traceback (most recent call last):
>  File
>
> 
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/testcase.py",
>    line 105, in run rc = apply(self.pred.func, args) File
> 
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/basic_tests.py",
>    line 76, in basic_checkout svntest.actions.run_and_verify_svn(None,
>  None, [], 'rm', G_path) File
>
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py",
> line 185, in run_and_verify_svn handle_output(expected_stderr, err,
> 'stderr', SVNExpectedStderr) File
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py",
> line 174, in handle_output compare_and_display_lines(message,
> output_type.upper(), expected, actual)
> NameError: global name 'message' is not defined
> FAIL:  basic_tests.py 1: basic checkout of a wc
>
> I'm using:
>
> $ python -V
> Python 2.1.3
>
> If I google I one of the first hits is me complaining about r7351!  As
> far as I can tell this use of nested functions requires a more recent
> Python, the testsuite is supposed to work with 2.1.3 isn't it?

Supposed to, yes. But, as a practical matter, very few people actually use 
Python less than 2.2 these days, so it is extremely easy for modern Python 
styles to creep in, and remain undetected for a while.


I suppose, if we are serious about python 2.0 compat, we ought to see if any 
of the people running svn-breakage systems would be willing to arrange for 
the tests to run with an old python.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org