You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by br...@apache.org on 2010/08/19 07:23:59 UTC

svn commit: r987020 - /incubator/thrift/trunk/configure.ac

Author: bryanduxbury
Date: Thu Aug 19 05:23:59 2010
New Revision: 987020

URL: http://svn.apache.org/viewvc?rev=987020&view=rev
Log:
THRIFT-850. build: Perl runtime requires Bit::Vector which may not be installed by default, but configure does not fail

Attached patch should do the following:

    * check for the existence of the Perl Bit::Vector module
    * warn the user that the Perl library won't be built if Bit::Vector doesn't exist
    * have the WITH_PERL conditional also require Bit::Vector (e.g. don't built the perl libs if the module isn't there)

Patch: Michael Lum

Modified:
    incubator/thrift/trunk/configure.ac

Modified: incubator/thrift/trunk/configure.ac
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/configure.ac?rev=987020&r1=987019&r2=987020&view=diff
==============================================================================
--- incubator/thrift/trunk/configure.ac (original)
+++ incubator/thrift/trunk/configure.ac Thu Aug 19 05:23:59 2010
@@ -119,8 +119,12 @@ AM_CONDITIONAL(WITH_PYTHON, [test -n "$P
 AX_THRIFT_LIB(perl, [Perl], yes)
 if test "$with_perl" = "yes"; then
   AC_PATH_PROG([PERL], [perl])
+  if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
+    AC_MSG_WARN([Perl Bit::Vector module not installed, skipping perl])
+    have_perl_bit_vector="no"
+  fi
 fi
-AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
+AM_CONDITIONAL(WITH_PERL, [test -n "$PERL" -a -z "$have_perl_bit_vector"])
 
 AX_THRIFT_LIB(php, [PHP], yes)
 if test "$with_php" = "yes"; then