You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/22 04:37:41 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43008: [SPARK-44113][BUILD][INFRA][DOCS] Drop support for Scala 2.12

HyukjinKwon commented on code in PR #43008:
URL: https://github.com/apache/spark/pull/43008#discussion_r1333866152


##########
docs/_plugins/copy_api_dirs.rb:
##########
@@ -26,8 +26,8 @@
     curr_dir = pwd
     cd("..")
 
-    puts "Running 'build/sbt -Pkinesis-asl clean compile unidoc' from " + pwd + "; this may take a few minutes..."
-    system("build/sbt -Pkinesis-asl clean compile unidoc") || raise("Unidoc generation failed")
+    puts "Running 'build/sbt -Pscala-2.13 -Pkinesis-asl clean compile unidoc' from " + pwd + "; this may take a few minutes..."

Review Comment:
   QQ, why do we need scala profile here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org