[GitHub] [ignite-3] ibessonov commented on a change in pull request #169: IGNITE-14745 Storage API for partitions.

[GitBox <gi...@apache.org>]

ibessonov commented on a change in pull request #169:
URL: https://github.com/apache/ignite-3/pull/169#discussion_r654198812



##########
File path: modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
##########
@@ -179,8 +179,6 @@ public NettyServer(
                  */
                 .option(ChannelOption.SO_BACKLOG, 128)
                 .option(ChannelOption.SO_REUSEADDR, true)
-                .childOption(ChannelOption.SO_LINGER, 0)

Review comment:
       These are duplicates

##########
File path: modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
##########
@@ -179,8 +179,6 @@ public NettyServer(
                  */
                 .option(ChannelOption.SO_BACKLOG, 128)
                 .option(ChannelOption.SO_REUSEADDR, true)
-                .childOption(ChannelOption.SO_LINGER, 0)

Review comment:
       These are duplicates, or are they? I'll recheck

##########
File path: modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
##########
@@ -179,8 +179,6 @@ public NettyServer(
                  */
                 .option(ChannelOption.SO_BACKLOG, 128)
                 .option(ChannelOption.SO_REUSEADDR, true)
-                .childOption(ChannelOption.SO_LINGER, 0)

Review comment:
       These are duplicates, or are they? I'll recheck
   EDIT: yes they are

##########
File path: modules/storage-api/src/main/java/org/apache/ignite/internal/storage/InvokeClosure.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.storage;
+
+import org.jetbrains.annotations.Nullable;
+
+/** */
+public interface InvokeClosure {
+    /**
+     * @param row Old row or {@code null} if old row not found.
+     */
+    void call(@Nullable DataRow row);
+
+    /**
+     * @return New row for {@link OperationType#WRITE} operation.
+     */
+    DataRow newRow();

Review comment:
       How else would you provide a new row?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org