You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/09/08 10:13:35 UTC
DO NOT REPLY [Bug 40442] New: - percent length not working in font-size for rtf output
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
Summary: percent length not working in font-size for rtf output
Product: Fop
Version: 0.92
Platform: All
OS/Version: All
Status: NEW
Keywords: PatchAvailable
Severity: normal
Priority: P2
Component: rtf
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: renaud.michel@defimedia.be
Using a relative font-size, like this
<fo:block font-size="120%">test</fo:block>
always gives the smallest font size possible.
This is due to the fact that in
org.apache.fop.render.rtf.FOPRtfAttributes.setHalfPoints(String,Length)
getValue is used without a context.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
spepping@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
------- Additional Comments From spepping@apache.org 2006-10-09 06:07 -------
Patch applied in revision 454369. Thanks.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
renaud.michel@defimedia.be changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|percent length not working |[PATCH] percent length not
|in font-size for rtf output |working in font-size for rtf
| |output
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
renaud.michel@defimedia.be changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |
------- Additional Comments From renaud.michel@defimedia.be 2006-09-16 18:27 -------
You are right, and it is not necessary to have a big and well-implemented
PercentBaseContext for this case.
Here, the context is only used for font calculation and so, looking at
FixedLength, PercentLength and LengthBase I only need here a context that is
non null.
I sent a new patch (against current trunk) that simply send a dummy
implementation of PercentBaseContext that fix my problem (just try the
helloworld example with a font-size="150%" on the fo:block with and without
this patch).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
------- Additional Comments From jeremias@apache.org 2006-09-11 06:48 -------
Creating LayoutManagers in RTF output is not really the right idea.
LayoutManagers are to be used only inside the "layout engine" which for RTF
isn't used. I realize it's a tempting move but from a design perspective, it is
wrong. A different solution has to be found. IMO, we have to have special
implementations for PercentBaseContext for output formats which don't use the
layout engine. These implementations could even be used by the layout managers,
thus removing the need to implement PercentBaseContext there.
If another committer disagrees with my statement, please reopen the issue.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40442] - percent length not working in font-size for rtf output
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
------- Additional Comments From renaud.michel@defimedia.be 2006-09-08 08:25 -------
Created an attachment (id=18840)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18840&action=view)
patch that add PercentBaseContext
The patch is against 0.92, but should apply to trunk as well, as the only
differences to these files are header diffs.
This is a proposed modification to org.apache.fop.render.rtf.FOPRtfAttributes
and org.apache.fop.render.rtf.TextAttributesConverter wich create
LayoutManagers to use them as PercentBaseContext.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442
renaud.michel@defimedia.be changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18840|0 |1
is obsolete| |
------- Additional Comments From renaud.michel@defimedia.be 2006-09-16 18:16 -------
Created an attachment (id=18876)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18876&action=view)
simpler fix
New, simpler fix for percent font problem in RTF output.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.