You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jomarko (via GitHub)" <gi...@apache.org> on 2025/09/23 15:26:36 UTC
[PR] kie-issues#2097: Unable to save the form changes in source fields - s… [incubator-kie-tools]
jomarko opened a new pull request, #3291:
URL: https://github.com/apache/incubator-kie-tools/pull/3291
…implified solution
This is part 2 for https://github.com/apache/incubator-kie-issues/issues/2097 and https://github.com/apache/incubator-kie-tools/pull/3284/files
It basically revert original solution and add `model.dispose()` call to another place, that was designed for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2097: Unable to save the form changes in source fields - s… [incubator-kie-tools]
Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on PR #3291:
URL: https://github.com/apache/incubator-kie-tools/pull/3291#issuecomment-3352435467
PR updated, all `dispose` calls are needed to:
- switch between forms
- switch for **Source** and **Connections** tabs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2097: Unable to save the form changes in source fields - s… [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg merged PR #3291:
URL: https://github.com/apache/incubator-kie-tools/pull/3291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2097: Unable to save the form changes in source fields - s… [incubator-kie-tools]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3291:
URL: https://github.com/apache/incubator-kie-tools/pull/3291#discussion_r2375642348
##########
packages/runtime-tools-process-enveloped-components/src/formDetails/envelope/components/FormEditor/FormEditorController.tsx:
##########
@@ -74,13 +74,11 @@ export class FormEditorEditorController implements FormEditorEditorApi {
noImplicitReturns: false,
alwaysStrict: false,
});
- const monacoModelUri = monaco.Uri.parse("file:///main.tsx"); // Ensures TSX compatibility
- const existingModel = monaco.editor.getModel(monacoModelUri);
-
- if (existingModel) {
- existingModel.dispose(); // Clean up the old model
- }
- this.model = monaco.editor.createModel(content, this.language, monacoModelUri);
+ this.model = monaco.editor.createModel(
+ content,
+ this.language,
+ monaco.Uri.parse("file:///main.tsx") // Ensures TSX compatibility
+ );
Review Comment:
Creating multiple models with the same URI can cause conflicts. Consider using a unique URI for each model instance or implementing proper cleanup before creating a new model with the same URI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org