[GitHub] [storm] Ethanlm commented on issue #3216: [STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator

[GitBox <gi...@apache.org>]

Ethanlm commented on issue #3216: [STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator
URL: https://github.com/apache/storm/pull/3216#issuecomment-591585220
 
 
   Good catch. But I think  there is a bug in this code:
   
   first assume `pre` and `post` are both empty to simplify discussion. 
   
   if every node is in the `skip` list, the first call of `hasNext` will return `false` (which is correct), the second call of `hasNext` will return `true` since `nextValueFromNode` is no longer `null`
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services