You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/12/02 01:02:26 UTC
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16806
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
[build-support] devtoolset-8 allows to build on CentOS 6
RHEL/CentOS 6 is beyond its EOL date already, but it doesn't hurt
to keep Kudu building on old build servers (even if that hardware
is close to its own EOL as well).
With this patch, I was able to rebuild all thirdparty components
and Kudu itself in DEBUG and RELEASE configuration after installing
devtoolset-8 on old CentOS 6 build server.
Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
---
M build-support/enable_devtoolset.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/16806/1
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16806
to look at the new patch set (#2).
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
[build-support] devtoolset-8 allows to build on CentOS 6
RHEL/CentOS 6 is beyond its EOL date already, but it doesn't hurt
to keep Kudu building on old build servers (even if that hardware
is close to its own EOL as well).
With this patch, I was able to rebuild all thirdparty components
and Kudu itself in DEBUG and RELEASE configuration after installing
devtoolset-8 on old CentOS 6 build server.
Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
---
M build-support/enable_devtoolset.sh
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/16806/2
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16806 )
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh@20
PS1, Line 20: # Enables the Red Hat devtoolset on RHEL 6 based systems and executes the
: # arguments. On non-RHEL 6 systems, the arguments are executed without changes
: # to the environment.
: # USAGE: ./enable_devtoolset.sh <command> <args>...
> Not this change but since you are here, it'd be good to update the comments
Good catch
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 02:55:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16806 )
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh@20
PS1, Line 20: # Enables the Red Hat devtoolset on RHEL 6 based systems and executes the
: # arguments. On non-RHEL 6 systems, the arguments are executed without changes
: # to the environment.
: # USAGE: ./enable_devtoolset.sh <command> <args>...
Not this change but since you are here, it'd be good to update the comments and add RHEL7 too.
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 01:32:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16806 )
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
[build-support] devtoolset-8 allows to build on CentOS 6
RHEL/CentOS 6 is beyond its EOL date already, but it doesn't hurt
to keep Kudu building on old build servers (even if that hardware
is close to its own EOL as well).
With this patch, I was able to rebuild all thirdparty components
and Kudu itself in DEBUG and RELEASE configuration after installing
devtoolset-8 on old CentOS 6 build server.
Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Reviewed-on: http://gerrit.cloudera.org:8080/16806
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/enable_devtoolset.sh
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16806 )
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh@20
PS1, Line 20: # Enables the Red Hat devtoolset and executes the arguments on RHEL-based
: # systems where the default C++ compiler does not support all features
: # necessary to compile Kudu from source (C++17). On other (newer) RHEL-based
: # systems and non-RHEL systems, the arguments are e
> Not this change but since you are here, it'd be good to update the comments
Done
http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh@20
PS1, Line 20: # Enables the Red Hat devtoolset and executes the arguments on RHEL-based
: # systems where the default C++ compiler does not support all features
: # necessary to compile Kudu from source (C++17). On other (newer) RHEL-based
: # systems and non-RHEL systems, the arguments are e
> Good catch
Done
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 03:54:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build-support] devtoolset-8 allows to build on CentOS 6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16806 )
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 15:52:49 +0000
Gerrit-HasComments: No