You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/29 08:17:41 UTC
[GitHub] [hbase] Apache-HBase commented on pull request #2469: HBASE-25112 Add new procedure metrics for master UI only
Apache-HBase commented on pull request #2469:
URL: https://github.com/apache/hbase/pull/2469#issuecomment-700531420
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 44s | master passed |
| +1 :green_heart: | checkstyle | 1m 37s | master passed |
| +1 :green_heart: | spotbugs | 3m 14s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 35s | the patch passed |
| -0 :warning: | checkstyle | 0m 15s | hbase-hadoop-compat: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) |
| -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 19 new + 9 unchanged - 0 fixed = 28 total (was 9) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 38s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| -1 :x: | spotbugs | 0m 42s | hbase-hadoop-compat generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 38m 51s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-hadoop-compat |
| | Dead store to assignMetricsOnMasterUI rather than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:[line 94] |
| | Dead store to closeMetricsOnMasterUI rather than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:[line 99] |
| | Dead store to moveMetricsOnMasterUI rather than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:[line 96] |
| | Dead store to openMetricsOnMasterUI rather than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:[line 98] |
| | Dead store to reopenMetricsOnMasterUI rather than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:[line 97] |
| | Dead store to unassignMetricsOnMasterUI rather than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:than field with same name in org.apache.hadoop.hbase.master.MetricsAssignmentManagerSourceImpl.init() At MetricsAssignmentManagerSourceImpl.java:[line 95] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2469/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2469 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 86da489d73b3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 5d926627ae |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2469/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2469/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2469/1/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html |
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: hbase-hadoop-compat hbase-procedure hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2469/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org