You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/21 09:50:50 UTC

[GitHub] [hive] kasakrisz opened a new pull request #1796: HIVE-24547: Fix acid_vectorization_original

kasakrisz opened a new pull request #1796:
URL: https://github.com/apache/hive/pull/1796


   ### What changes were proposed in this pull request?
   When collecting identifiers to expanded query text Convert replacement text to lower case when adding it to `UnparseTranslator`.
   
   ### Why are the changes needed?
   Virtual column identifiers like `ROW__ID` are converted to lower case when added to `UnparseTranslator` except when the query contains joins.
   ```
   select o1.ROW__ID r1, o1.* from over10k_orc o1 join over10k_orc o2
   on o1.ROW__ID.rowid == o2.ROW__ID.rowid and o1.ROW__ID.writeid == o2.ROW__ID.writeid and o1.ROW__ID.bucketid == o2.ROW__ID.bucketid;
   
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   ```
   mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=acid_vectorization_original.q -pl itests/qtest -Pitests
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] kasakrisz merged pull request #1796: HIVE-24547: Fix acid_vectorization_original

Posted by GitBox <gi...@apache.org>.
kasakrisz merged pull request #1796:
URL: https://github.com/apache/hive/pull/1796


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org