You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/05/28 11:46:21 UTC
[GitHub] [guacamole-server] oharboe opened a new pull request #342: GUACAMOLE-1064: add Norwegian keyboard
oharboe opened a new pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342
@jmoehlma Best guess... How do I test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman commented on pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342#issuecomment-850371678
@oharboe: Looks fine without having an actual keyboard to test it with. Unfortunately I don't have a way to test, either :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper merged pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper merged pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342#issuecomment-850711927
@oharboe, no, there is no automated test mechanism for keyboard layout behavior. The only way to test that a new keyboard layout behaves correctly is to deploy and directly test against an RDP connection using that layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342#discussion_r644421036
##########
File path: src/protocols/rdp/Makefile.am
##########
@@ -241,7 +241,8 @@ rdp_keymaps = \
$(srcdir)/keymaps/pt_br_qwerty.keymap \
$(srcdir)/keymaps/sv_se_qwerty.keymap \
$(srcdir)/keymaps/da_dk_qwerty.keymap \
- $(srcdir)/keymaps/tr_tr_qwerty.keymap
+ $(srcdir)/keymaps/tr_tr_qwerty.keymap \
+ $(srcdir)/keymaps/no_no_qwerty.keymap
Review comment:
With the exception of "base" and "failsafe" (which are special cases) and "da_dk_qwerty" (which somehow slipped in here unsorted), the files listed here are being maintained in sorted order. Please move your new keymap up in the list such that sorted order is maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] oharboe commented on pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
oharboe commented on pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342#issuecomment-850404461
@necouchman Is there a way to test this beyond manual integration testing, i.e. set up a couple of machines w/Guacamole?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] oharboe commented on pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
oharboe commented on pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342#issuecomment-852115712
@mike-jumper Tested. Seems to work :-)
`sudo showkey` was useful to find scancodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #342: GUACAMOLE-1064: add Norwegian keyboard
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #342:
URL: https://github.com/apache/guacamole-server/pull/342#discussion_r644421036
##########
File path: src/protocols/rdp/Makefile.am
##########
@@ -241,7 +241,8 @@ rdp_keymaps = \
$(srcdir)/keymaps/pt_br_qwerty.keymap \
$(srcdir)/keymaps/sv_se_qwerty.keymap \
$(srcdir)/keymaps/da_dk_qwerty.keymap \
- $(srcdir)/keymaps/tr_tr_qwerty.keymap
+ $(srcdir)/keymaps/tr_tr_qwerty.keymap \
+ $(srcdir)/keymaps/no_no_qwerty.keymap
Review comment:
With the exception of "base" and "failsafe" (which are special cases) and "da_dk_qwerty" (which somehow slipped in here unsorted), the files listed here are being maintained in sorted order. Please move your new keymap up in the list such that sorted order is maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org