You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/10/19 08:30:42 UTC

[GitHub] tajo pull request: TAJO-1124: RowWriter::putText and RowWriter::pu...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/204

    TAJO-1124: RowWriter::putText and RowWriter::putBlob should take offset ...

    ...and length params.
    
    I added the proposed API and an unit test for the API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1124

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit 58bc69d37ba24b365f43a87b0a509163d584a7fc
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-10-19T06:28:54Z

    TAJO-1124: RowWriter::putText and RowWriter::putBlob should take offset and length params.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1124: RowWriter::putText and RowWriter::pu...

Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/204#issuecomment-59697310
  
    +1 LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1124: RowWriter::putText and RowWriter::pu...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik closed the pull request at:

    https://github.com/apache/tajo/pull/204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1124: RowWriter::putText and RowWriter::pu...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/204#issuecomment-59697851
  
    committed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---