[GitHub] [spark] cloud-fan commented on a change in pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31696:
URL: https://github.com/apache/spark/pull/31696#discussion_r585282588



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -203,12 +203,13 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
     case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, _) =>
       DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
 
-    case DescribeColumn(ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended) =>
+    case DescribeColumn(
+         ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended, _) =>
       // For views, the column will not be resolved by `ResolveReferences` because
       // `ResolvedView` stores only the identifier.
       DescribeColumnCommand(ident.asTableIdentifier, column.nameParts, isExtended)

Review comment:
       shall we pass the output to the v1 command as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org