[GitHub] [skywalking] lizan commented on issue #6019: Add package definition on data collection protocol

[GitBox <gi...@apache.org>]

lizan commented on issue #6019:
URL: https://github.com/apache/skywalking/issues/6019#issuecomment-747194576


   > Quick conclusion: adding package name changes the service name, that breaks all existing agents, I'm still wondering whether we could solve it in cpp2sky side, but package name definitely needs to be added someday when we decide to have break changes
   
   There are ways to provide this compatibility:
   1. we should be able to add package to data messages, this doesn't break wire compatibility (unless we use protobuf.Any, which I don't think this is the case).
   2. make a compat service that have same signature in server-side only, keep with current implementation.
   3. add package to protobuf service, which shares the underlying implementation with 2.
   
   In this way the server would be able to handle both version of service, and it won't break wire compatibility.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org