You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/21 16:57:46 UTC
[GitHub] [flink] rmetzger opened a new pull request #11178: [hotfix]
Stabilize python tests
rmetzger opened a new pull request #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178
These are some examples of failing python tests:
- https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5408&view=logs&j=dee070b7-d526-572b-39a4-ac3b24b600ee&t=b950229e-d858-5111-b60e-d71ec3d8da1d
- https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5409&view=logs&j=dee070b7-d526-572b-39a4-ac3b24b600ee&t=b950229e-d858-5111-b60e-d71ec3d8da1d
- https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5410&view=results
- https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5404&view=logs&j=dee070b7-d526-572b-39a4-ac3b24b600ee&t=b950229e-d858-5111-b60e-d71ec3d8da1d
They all have connection timeout errors:
```
INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:04 min
[INFO] Finished at: 2020-02-21T12:23:36+00:00
[INFO] Final Memory: 265M/4463M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project flink-connector-elasticsearch7_2.11: Could not resolve dependencies for project org.apache.flink:flink-connector-elasticsearch7_2.11:jar:1.11-SNAPSHOT: Failed to collect dependencies at org.elasticsearch.client:elasticsearch-rest-high-level-client:jar:7.5.1 -> org.elasticsearch:elasticsearch:jar:7.5.1 -> org.apache.lucene:lucene-core:jar:8.3.0: Failed to read artifact descriptor for org.apache.lucene:lucene-core:jar:8.3.0: Could not transfer artifact org.apache.lucene:lucene-solr-grandparent:pom:8.3.0 from/to google-maven-central (https://maven-central-eu.storage-download.googleapis.com/maven2/): GET request of: org/apache/lucene/lucene-solr-grandparent/8.3.0/lucene-solr-grandparent-8.3.0.pom from google-maven-central failed: Connection reset -> [Help 1]
```
This hotfix introduces two mitigations:
a) we fail the build if maven fails
b) we use a cache for the python build, so that we don't have to excessively use the mirror
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150066458 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150066458) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #11178: [hotfix] Stabilize
python tests
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589932887
@zentol looks like Ci bot didn't find the second build for AZP: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5447&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150066458 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150066458) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150066458 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:5e4b742577824a69966ee284b055495bbc17644a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150116897 TriggerType:PUSH TriggerID:5e4b742577824a69966ee284b055495bbc17644a
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150066458) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436)
* 5e4b742577824a69966ee284b055495bbc17644a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150116897)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11178: [hotfix] Stabilize
python tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11178:
[hotfix] Stabilize python tests
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#discussion_r382716845
##########
File path: tools/azure_controller.sh
##########
@@ -173,6 +173,13 @@ elif [ $STAGE != "$STAGE_CLEANUP" ]; then
PY_MVN="$PY_MVN -Drat.skip=true"
${PY_MVN}
echo "Done compiling ... "
Review comment:
let's move this below the error check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11178:
[hotfix] Stabilize python tests
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#discussion_r382716947
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -98,10 +98,15 @@ jobs:
path: $(CACHE_FLINK_DIR)
artifact: FlinkCompileCacheDir-${{parameters.stage_name}}
- # recreate "build-target" symlink for python tests
- - script: |
- ln -snf $(CACHE_FLINK_DIR)/flink-dist/target/flink-*-SNAPSHOT-bin/flink-*-SNAPSHOT $(CACHE_FLINK_DIR)/build-target
- displayName: Recreate 'build-target' symlink
+ # only for the python stage (which runs a full mvn install), download the cache
+ - task: Cache@2
+ condition: eq(variables['module'], 'python')
+ inputs:
+ key: $(CACHE_KEY)
+ restoreKeys: $(CACHE_FALLBACK_KEY)
+ path: $(MAVEN_CACHE_FOLDER)
+ continueOnError: true # continue the build even if the cache fails.
+ displayName: Cache Maven local repo
# Test
Review comment:
add an empty line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150066458 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:5e4b742577824a69966ee284b055495bbc17644a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:5e4b742577824a69966ee284b055495bbc17644a
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150066458) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436)
* 5e4b742577824a69966ee284b055495bbc17644a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
rmetzger edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589932887
Thank you for your review! Merging ...
@zentol looks like Ci bot didn't find the second build for AZP: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5447&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger merged pull request #11178: [hotfix] Stabilize
python tests
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11178: [hotfix] Stabilize
python tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589742222
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b2e002eb9b0f340f4efd6e79b22c19d9b588993f (Fri Feb 21 17:01:05 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150066458 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:5e4b742577824a69966ee284b055495bbc17644a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150116897 TriggerType:PUSH TriggerID:5e4b742577824a69966ee284b055495bbc17644a
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150066458) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436)
* 5e4b742577824a69966ee284b055495bbc17644a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150116897)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11178: [hotfix]
Stabilize python tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11178: [hotfix] Stabilize python tests
URL: https://github.com/apache/flink/pull/11178#issuecomment-589751914
<!--
Meta data
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150066458 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
Hash:b2e002eb9b0f340f4efd6e79b22c19d9b588993f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436 TriggerType:PUSH TriggerID:b2e002eb9b0f340f4efd6e79b22c19d9b588993f
-->
## CI report:
* b2e002eb9b0f340f4efd6e79b22c19d9b588993f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150066458) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5436)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services