You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2023/01/09 09:52:38 UTC
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1487: fix cmake warning && bootstrap.sh improvements
martinzink opened a new pull request, #1487:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1487
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1487: MINIFICPP-2025 Eliminate cmake CMP0135 warnings
Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #1487: MINIFICPP-2025 Eliminate cmake CMP0135 warnings
URL: https://github.com/apache/nifi-minifi-cpp/pull/1487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1487: MINIFICPP-2025 Eliminate cmake CMP0135 warnings
Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1487:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1487#discussion_r1064994996
##########
cmake/BundledLibXml2.cmake:
##########
@@ -38,6 +38,10 @@ function(use_bundled_libxml2 SOURCE_DIR BINARY_DIR)
"-DCMAKE_INSTALL_PREFIX=${BINARY_DIR}/thirdparty/libxml2-install")
endif()
+ if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.24)
+ cmake_policy(SET CMP0135 OLD) # Restore the timestamps from the archive https://gitlab.kitware.com/cmake/cmake/-/issues/24003
+ endif()
Review Comment:
You can keep the policy and just add `DOWNLOAD_EXTRACT_TIMESTAMP ON` to ExternalProject_Add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1487: MINIFICPP-2025 Eliminate cmake CMP0135 warnings
Posted by GitBox <gi...@apache.org>.
martinzink commented on code in PR #1487:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1487#discussion_r1065465776
##########
cmake/BundledLibXml2.cmake:
##########
@@ -38,6 +38,10 @@ function(use_bundled_libxml2 SOURCE_DIR BINARY_DIR)
"-DCMAKE_INSTALL_PREFIX=${BINARY_DIR}/thirdparty/libxml2-install")
endif()
+ if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.24)
+ cmake_policy(SET CMP0135 OLD) # Restore the timestamps from the archive https://gitlab.kitware.com/cmake/cmake/-/issues/24003
+ endif()
Review Comment:
Yeah that was my original intent, but the latest cmake on centos7 doesnt have this feature, so that would only work if I duplicated the whole ExternalProject_Add into an `if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.24)` statement.
I also tried to put the "DOWNLOAD_EXTRACT_TIMESTAMP ON" and "" (based on cmakeversion) into a variable and pass that into the ExternalProject_Add but I wanst able to make that work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org