You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/10 09:02:48 UTC
[GitHub] [skywalking] zhyyu opened a new issue, #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
zhyyu opened a new issue, #9028:
URL: https://github.com/apache/skywalking/issues/9028
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Add plugin.jdbc.trace_sql_parameters into agent CDS.
### Use case
Sometimes don't want to change the agent config and restart the application to see the sql parameter. Add plugin.jdbc.trace_sql_parameters into agent CDS make it can be changed dynamic.
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124710496
You don't need `bootservice`. DCS has a kernel level service already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhyyu commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
zhyyu commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124461168
> @zhyyu Are you working on this?
Yes, I am working on it. I meet some classloader issue, `org.apache.skywalking.apm.plugin.jdbc.JDBCPluginConfig.Plugin.JDBC` is loaded by two different `AgentClassLoader` . I am finding out the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhyyu commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
zhyyu commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124571055
> AgentConfigChangeWatcher
I create a new bootservice and watcher in jdbc-commons package. If i do not create a new service, can I reuse `ContextManagerExtendService` or other existed bootservice to register my new warcher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhyyu commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
zhyyu commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124465172
I write a `JDBCPluginDynamicConfigService` `BootService` register the watcher change the config, but business thread use another classloader to see `JDBCPluginConfig.Plugin.JDBC.TRACE_SQL_PARAMETERS`, so the watcher don't work..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124710175
Why do you make things so complex? You just need a watcher, and when the JDBC plugin is intercepting Driver initialization, you register this into the kernel, then you could have everything you need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
URL: https://github.com/apache/skywalking/issues/9028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124409776
@zhyyu Are you working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9028:
URL: https://github.com/apache/skywalking/issues/9028#issuecomment-1124501461
I think you don't need a service, you should have a watcher(AgentConfigChangeWatcher). Have you checked this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org