You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/02/18 09:44:29 UTC
Review Request 18204: Added != operator to future.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18204/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/future.hpp aaf17af2eef0f1bf7062aa04469f1fa27bb4cfbe
Diff: https://reviews.apache.org/r/18204/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 18204: Added != operator to future.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18204/#review34709
-----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/18204/#comment64920>
it's good practice to define != in terms of ==. Ie, this would be:
return !(*this == that);
- Dominic Hamon
On Feb. 18, 2014, 12:44 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18204/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 12:44 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp aaf17af2eef0f1bf7062aa04469f1fa27bb4cfbe
>
> Diff: https://reviews.apache.org/r/18204/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18204: Added != operator to future.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18204/#review34699
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 18, 2014, 12:44 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18204/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 12:44 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp aaf17af2eef0f1bf7062aa04469f1fa27bb4cfbe
>
> Diff: https://reviews.apache.org/r/18204/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18204: Added != operator to future.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18204/#review34703
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 18, 2014, 8:44 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18204/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 8:44 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp aaf17af2eef0f1bf7062aa04469f1fa27bb4cfbe
>
> Diff: https://reviews.apache.org/r/18204/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>