You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2024/01/31 09:09:17 UTC
[PR] [fix](macut) using namespace for regex [doris]
dataroaring opened a new pull request, #30642:
URL: https://github.com/apache/doris/pull/30642
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1919309349
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918758076
TeamCity be ut coverage result:
Function Coverage: 36.18% (8626/23840)
Line Coverage: 28.25% (70556/249759)
Region Coverage: 27.25% (36409/133601)
Branch Coverage: 24.04% (18647/77570)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9cd48e418c6d02f3fae57cf77e372d901a6eb062_9cd48e418c6d02f3fae57cf77e372d901a6eb062/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1919309434
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918764572
<details>
<summary>TPC-DS: <b>Total hot run time: 174831 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cd48e418c6d02f3fae57cf77e372d901a6eb062, data reload: false
query1 921 334 317 317
query2 6582 1947 1979 1947
query3 6711 201 192 192
query4 31721 22045 22149 22045
query5 4457 347 418 347
query6 250 157 157 157
query7 4608 253 252 252
query8 249 169 172 169
query9 9003 2249 2243 2243
query10 407 211 217 211
query11 18365 15316 15218 15218
query12 120 65 63 63
query13 1616 377 362 362
query14 9859 7522 7132 7132
query15 235 176 183 176
query16 7524 256 249 249
query17 1865 477 468 468
query18 1966 256 258 256
query19 346 130 138 130
query20 68 70 73 70
query21 192 128 132 128
query22 4935 4538 4707 4538
query23 31010 30273 30323 30273
query24 10712 2744 2741 2741
query25 511 302 306 302
query26 709 131 131 131
query27 2155 286 283 283
query28 5865 1831 1839 1831
query29 907 613 605 605
query30 282 132 139 132
query31 948 718 710 710
query32 91 51 50 50
query33 612 207 198 198
query34 828 452 459 452
query35 893 784 751 751
query36 1224 1193 1242 1193
query37 99 58 56 56
query38 3258 3188 3178 3178
query39 1308 1280 1243 1243
query40 193 82 82 82
query41 35 35 37 35
query42 91 80 80 80
query43 518 492 482 482
query44 1058 673 682 673
query45 195 184 175 175
query46 1035 644 632 632
query47 1492 1525 1516 1516
query48 409 317 309 309
query49 1081 276 282 276
query50 696 312 312 312
query51 5220 5188 5116 5116
query52 88 84 75 75
query53 323 261 257 257
query54 264 181 180 180
query55 80 78 73 73
query56 178 154 157 154
query57 991 940 894 894
query58 176 153 158 153
query59 2549 2315 2316 2315
query60 196 167 175 167
query61 82 82 83 82
query62 630 365 361 361
query63 274 259 263 259
query64 4834 3679 3379 3379
query65 3243 3211 3216 3211
query66 949 310 321 310
query67 14728 14328 14150 14150
query68 4338 484 505 484
query69 433 303 308 303
query70 1541 1501 1550 1501
query71 285 216 210 210
query72 5524 3080 2805 2805
query73 693 325 305 305
query74 6624 6286 6258 6258
query75 2930 2288 2298 2288
query76 2547 945 968 945
query77 353 223 227 223
query78 9167 8857 8660 8660
query79 2554 483 486 483
query80 2195 318 309 309
query81 536 197 204 197
query82 768 75 80 75
query83 251 116 119 116
query84 281 75 77 75
query85 2050 353 315 315
query86 507 390 388 388
query87 3416 3253 3267 3253
query88 3749 2158 2155 2155
query89 419 352 340 340
query90 1920 185 186 185
query91 147 115 118 115
query92 56 42 41 41
query93 2792 422 432 422
query94 1286 161 161 161
query95 509 465 442 442
query96 618 309 318 309
query97 4259 4111 4097 4097
query98 212 183 186 183
query99 1146 704 681 681
Total cold run time: 279126 ms
Total hot run time: 174831 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918744382
<details>
<summary>TPC-H: <b>Total hot run time: 36398 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cd48e418c6d02f3fae57cf77e372d901a6eb062, data reload: false
------ Round 1 ----------------------------------
q1 17657 4799 4364 4364
q2 2041 136 129 129
q3 10609 891 901 891
q4 4695 705 686 686
q5 7692 2717 2806 2717
q6 183 119 118 118
q7 1117 708 695 695
q8 9267 1966 1976 1966
q9 7213 6292 6209 6209
q10 8063 2393 2408 2393
q11 404 205 211 205
q12 752 273 282 273
q13 18005 3310 3239 3239
q14 297 246 244 244
q15 523 503 490 490
q16 453 404 408 404
q17 923 598 513 513
q18 6681 5917 5910 5910
q19 1566 1346 1338 1338
q20 626 357 340 340
q21 6932 3003 2968 2968
q22 796 306 314 306
Total cold run time: 106495 ms
Total hot run time: 36398 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4434 4428 4395 4395
q2 321 220 231 220
q3 2963 2862 2790 2790
q4 1882 1653 1619 1619
q5 5149 5271 5206 5206
q6 194 113 112 112
q7 2110 1738 1768 1738
q8 3072 3203 3206 3203
q9 8286 8293 8286 8286
q10 5783 3467 3593 3467
q11 539 458 455 455
q12 730 579 564 564
q13 11228 3038 3070 3038
q14 286 245 259 245
q15 527 489 482 482
q16 496 451 472 451
q17 1865 1656 1672 1656
q18 8079 7673 7593 7593
q19 9402 1529 1553 1529
q20 2138 1887 1933 1887
q21 4952 4567 4624 4567
q22 549 456 481 456
Total cold run time: 74985 ms
Total hot run time: 53959 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 closed pull request #30642: [fix](macut) using namespace for regex
URL: https://github.com/apache/doris/pull/30642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on code in PR #30642:
URL: https://github.com/apache/doris/pull/30642#discussion_r1473721328
##########
be/src/olap/delete_handler.cpp:
##########
@@ -303,7 +303,7 @@ Status DeleteHandler::parse_condition(const std::string& condition_str, TConditi
// group3: ((?:[\s\S]+)?) matches "1597751948193618247 and length(source)<1;\n;\n"
const char* const CONDITION_STR_PATTERN =
R"(([\w$#%]+)\s*((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>=)|(?:<=)|(?:\*=)|(?:IS))\s*('((?:[\s\S]+)?)'|(?:[\s\S]+)?))";
- regex ex(CONDITION_STR_PATTERN);
+ boost::regex ex(CONDITION_STR_PATTERN);
Review Comment:
The following `regex_match` should be modified too.
`regex_error` -> `boost::regex_error`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918780062
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 9cd48e418c6d02f3fae57cf77e372d901a6eb062 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918682199
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918698259
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on code in PR #30642:
URL: https://github.com/apache/doris/pull/30642#discussion_r1473721328
##########
be/src/olap/delete_handler.cpp:
##########
@@ -303,7 +303,7 @@ Status DeleteHandler::parse_condition(const std::string& condition_str, TConditi
// group3: ((?:[\s\S]+)?) matches "1597751948193618247 and length(source)<1;\n;\n"
const char* const CONDITION_STR_PATTERN =
R"(([\w$#%]+)\s*((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>=)|(?:<=)|(?:\*=)|(?:IS))\s*('((?:[\s\S]+)?)'|(?:[\s\S]+)?))";
- regex ex(CONDITION_STR_PATTERN);
+ boost::regex ex(CONDITION_STR_PATTERN);
Review Comment:
The following `regex_error` should be modified too.
`regex_error` -> `boost::regex_error`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1920402255
Duplicated. See #30652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](macut) using namespace for regex [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30642:
URL: https://github.com/apache/doris/pull/30642#issuecomment-1918774537
<details>
<summary>ClickBench: <b>Total hot run time: 31.49 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cd48e418c6d02f3fae57cf77e372d901a6eb062, data reload: false
query1 0.04 0.03 0.03
query2 0.05 0.02 0.02
query3 0.23 0.06 0.06
query4 1.66 0.10 0.10
query5 0.53 0.52 0.51
query6 1.19 0.63 0.61
query7 0.02 0.01 0.01
query8 0.04 0.03 0.02
query9 0.53 0.51 0.50
query10 0.55 0.55 0.56
query11 0.11 0.08 0.08
query12 0.11 0.09 0.10
query13 0.60 0.60 0.61
query14 0.80 0.79 0.79
query15 0.78 0.79 0.78
query16 0.39 0.37 0.38
query17 0.95 1.00 0.96
query18 0.23 0.30 0.23
query19 1.80 1.82 1.76
query20 0.01 0.00 0.01
query21 15.42 0.59 0.56
query22 2.47 2.22 2.60
query23 17.22 0.76 0.77
query24 2.32 1.05 1.11
query25 0.36 0.27 0.24
query26 0.43 0.15 0.14
query27 0.05 0.05 0.04
query28 11.50 0.84 0.83
query29 12.59 3.08 3.09
query30 0.66 0.53 0.53
query31 2.78 0.35 0.35
query32 3.37 0.48 0.48
query33 3.18 3.25 3.21
query34 15.75 4.31 4.45
query35 4.33 4.31 4.33
query36 1.10 1.06 1.05
query37 0.06 0.05 0.05
query38 0.04 0.03 0.02
query39 0.02 0.01 0.01
query40 0.16 0.13 0.13
query41 0.07 0.02 0.02
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 104.55 s
Total hot run time: 31.49 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org