You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/19 13:55:52 UTC
[GitHub] [iotdb] mychaow commented on pull request #2867: IOTDB-1241 support redirect query for cluster
mychaow commented on pull request #2867:
URL: https://github.com/apache/iotdb/pull/2867#issuecomment-802851185
> Despite your effort that should be thanked, the current implementation is not very efficient, because the decision of redirect or not is made **AFTER** readers are created, which means a lot of resources have already been wasted by the time the decision is made. Moreover, I wonder if you have released the resources properly after the decision.
>
> I would recommend you do the redirection check **BEFORE** readers are created, and maybe it is done right after the physical plan is generated with the help of the partition table.
Ok, I will think about whether the plan could be redirected to the right node with the help of the partition table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org