You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/12 11:46:56 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4583: Externalize TLS version on Quota's mailing
GutoVeronezi opened a new pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583
### Description
Some servers (like [microsoft](https://docs.microsoft.com/en-us/microsoft-365/compliance/prepare-tls-1.2-in-office-365?view=o365-worldwide)) are deprecating TLSv1 and TLSv1.1.
On Quota's mailing settings, ACS uses the protocol `TLSv1`; therefore, operators do not have options to choose which version they want to use.
This PR intends to externalize the protocol setting on Quota's mailing.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### How Has This Been Tested?
It has been tested locally on a test lab.
1. I had Enabled Quota's plugin on the management server and configured it to use Gmail's SMTP server.
```
server address: smtp.gmail.com
username: gmail address
password: gmail password
port (TLS): 587
```
2. On `Quota - All Accounts`, I added 10 credits to my user and set 20 as min balance.
3. I had added an gmail address to Accounts > \<account\> > Users - Email.
4. I allowed `Less secure app access` on my Google account.
5. I had restarted management server.
6. And I called `quota update` API via Cloudmonkey.
7. In Gmail, we have an option to `show original` message, which provides the TLS version and the cipher. So I changed the configuration some times and sent some alerts to verify if both versions, in configuration and gmail, are the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-782464898
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-783998036
not sure if smoke tests touch this but
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-781937268
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-784414599
<b>Trillian test result (tid-3599)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34235 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4583-t3599-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-781937554
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-782445563
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-783998501
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-782017911
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4583:
URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-782446431
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org