You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:06:41 UTC

[GitHub] [arrow] aucahuasi commented on a diff in pull request #14226: ARROW-17599: [C++] Change the way how arrow reads parquet buffered files

aucahuasi commented on code in PR #14226:
URL: https://github.com/apache/arrow/pull/14226#discussion_r985922268


##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -2407,6 +2407,66 @@ TEST(TestArrowReadWrite, GetRecordBatchReaderNoColumns) {
   ASSERT_EQ(actual_batch->num_rows(), num_rows);
 }
 
+TEST(TestArrowReadWrite, GetRecordBatchGenerator2) {

Review Comment:
   Thanks Weston, do you have an idea about how to make such test? I think we will still need to keep data in RAM right? given that `ReadRangeCache::read` is retaining the contents of the buffered data until the reader expires.
   Do you think is a good idea to use `TestArrowReadWrite.GetRecordBatchGenerator` as base for writing the new test you are requesting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org