You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by Michal Fojtik <mf...@redhat.com> on 2010/10/05 08:55:26 UTC

Re: [PATCH] Fix typo in key_name for client's create_instance method

On 04/10/10 16:38 -0400, Ben Browning wrote:
>---
> client/lib/deltacloud.rb |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/client/lib/deltacloud.rb b/client/lib/deltacloud.rb
>index 0eeb4e4..21d69ef 100644
>--- a/client/lib/deltacloud.rb
>+++ b/client/lib/deltacloud.rb
>@@ -261,7 +261,7 @@ module DeltaCloud
>       end
>       declare_entry_points_methods(@entry_points)
>     end
>-    
>+
>     def create_key(opts={}, &block)
>       params = { :name => opts[:name] }
>       key = nil
>@@ -293,7 +293,7 @@ module DeltaCloud
>       ( params[:realm_id] = realm_id ) if realm_id
>       ( params[:name] = name ) if name
>       ( params[:user_data] = user_data ) if user_data
>-      ( params[:keyname] = user_data ) if key_name
>+      ( params[:keyname] = key_name ) if key_name

ACK. Good catch

> 
>       if opts[:hardware_profile].is_a?(String)
>         params[:hwp_id] = opts[:hardware_profile]
>-- 
>1.7.2.1
>

-- 
--------------------------------------------------------
Michal Fojtik, mfojtik@redhat.com
Deltacloud API: http://deltacloud.org
--------------------------------------------------------

Re: [PATCH] Fix typo in key_name for client's create_instance method

Posted by Michal Fojtik <mf...@redhat.com>.
On 06/10/10 07:59 -0400, Benjamin Browning wrote:
>
>On Oct 5, 2010, at 2:55 AM, Michal Fojtik wrote:
>> 
>> ACK. Good catch
>
>
>Thank you for ACKing. Would you mind also committing the fix for me?

Of course, commited to SVN.

   -- Michal

-- 
--------------------------------------------------------
Michal Fojtik, mfojtik@redhat.com
Deltacloud API: http://deltacloud.org
--------------------------------------------------------

Re: [PATCH] Fix typo in key_name for client's create_instance method

Posted by Benjamin Browning <bb...@redhat.com>.
On Oct 5, 2010, at 2:55 AM, Michal Fojtik wrote:
> 
> ACK. Good catch


Thank you for ACKing. Would you mind also committing the fix for me?

Ben