You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/20 10:56:45 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #11344: feat: annotations REST API
dpgaspar opened a new pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.82%`.
> The diff coverage is `87.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 60.79% -4.83%
==========================================
Files 834 412 -422
Lines 39559 25657 -13902
Branches 3610 0 -3610
==========================================
- Hits 25959 15599 -10360
+ Misses 13492 10058 -3434
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.79% <87.42%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2c13931](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.01%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.60% -4.02%
==========================================
Files 834 412 -422
Lines 39559 25667 -13892
Branches 3610 0 -3610
==========================================
- Hits 25959 15812 -10147
+ Misses 13492 9855 -3637
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.60% <87.35%> (+0.82%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [491 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.13%`.
> The diff coverage is `87.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.48% -4.14%
==========================================
Files 834 856 +22
Lines 39559 40586 +1027
Branches 3610 3662 +52
==========================================
- Hits 25959 24956 -1003
- Misses 13492 15449 +1957
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `60.79% <87.42%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [268 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2c13931](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#discussion_r509684969
##########
File path: superset/annotation_layers/annotations/dao.py
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import List, Optional
+
+from sqlalchemy.exc import SQLAlchemyError
+
+from superset.dao.base import BaseDAO
+from superset.dao.exceptions import DAODeleteFailedError
+from superset.extensions import db
+from superset.models.annotations import Annotation
+
+logger = logging.getLogger(__name__)
+
+
+class AnnotationDAO(BaseDAO):
+ model_cls = Annotation
+
+ @staticmethod
+ def bulk_delete(models: Optional[List[Annotation]], commit: bool = True) -> None:
+ item_ids = [model.id for model in models] if models else []
+ try:
+ db.session.query(Annotation).filter(Annotation.id.in_(item_ids)).delete(
+ synchronize_session="fetch"
+ )
+ if commit:
+ db.session.commit()
+ except SQLAlchemyError:
+ if commit:
+ db.session.rollback()
+ raise DAODeleteFailedError()
+
+ @staticmethod
+ def validate_uniqueness(layer_id: int, short_descr: str) -> bool:
+ query = db.session.query(Annotation).filter(
+ Annotation.short_descr == short_descr, Annotation.layer_id == layer_id
+ )
+ return not db.session.query(query.exists()).scalar()
+
+ @staticmethod
+ def validate_update_uniqueness(
+ annotation_id, layer_id: int, short_descr: str
Review comment:
nit:
```suggestion
annotation_id: int, layer_id: int, short_descr: str
```
##########
File path: tests/core_tests.py
##########
@@ -199,11 +199,16 @@ def test_annotation_json_endpoint(self):
self.assertIn("id", resp_annotations["result"][0])
self.assertIn("name", resp_annotations["result"][0])
- layer = self.get_resp(
+ response = self.get_resp(
f"/superset/annotation_json/{layer.id}?form_data="
+ quote(json.dumps({"time_range": "100 years ago : now"}))
)
- self.assertIn("my_annotation", layer)
+ self.assertIn("my_annotation", response)
Review comment:
nit, while at it, perhaps do
```suggestion
assert "my_annotation" in response
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.02%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.59% -4.03%
==========================================
Files 834 856 +22
Lines 39559 40596 +1037
Branches 3610 3662 +52
==========================================
- Hits 25959 25004 -955
- Misses 13492 15411 +1919
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `60.96% <87.35%> (+0.17%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [258 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.26%`.
> The diff coverage is `85.01%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.36% -4.27%
==========================================
Files 834 410 -424
Lines 39559 25469 -14090
Branches 3610 0 -3610
==========================================
- Hits 25959 15628 -10331
+ Misses 13492 9841 -3651
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.36% <85.01%> (+0.57%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `80.62% <80.62%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <88.46%> (ø)` | |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...bf9baf4](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `2.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 62.66% -2.96%
==========================================
Files 834 445 -389
Lines 39559 14890 -24669
Branches 3610 3652 +42
==========================================
- Hits 25959 9331 -16628
+ Misses 13492 5378 -8114
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.66% <ø> (-0.06%)` | :arrow_down: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [578 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...e0e7bb6](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 62.60% -3.02%
==========================================
Files 834 444 -390
Lines 39559 14776 -24783
Branches 3610 3613 +3
==========================================
- Hits 25959 9251 -16708
+ Misses 13492 5344 -8148
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.60% <ø> (-0.11%)` | :arrow_down: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [574 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...c79b6f7](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.01%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.60% -4.02%
==========================================
Files 834 412 -422
Lines 39559 25667 -13892
Branches 3610 0 -3610
==========================================
- Hits 25959 15812 -10147
+ Misses 13492 9855 -3637
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.60% <87.35%> (+0.82%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [491 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...72962c3](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.85% -9.77%
==========================================
Files 834 406 -428
Lines 39559 13601 -25958
Branches 3610 3450 -160
==========================================
- Hits 25959 7597 -18362
+ Misses 13492 5834 -7658
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.85% <ø> (-0.13%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [673 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...72962c3](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.67%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 60.94% -4.68%
==========================================
Files 834 412 -422
Lines 39559 25647 -13912
Branches 3610 0 -3610
==========================================
- Hits 25959 15630 -10329
+ Misses 13492 10017 -3475
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.94% <87.35%> (+0.16%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `81.65% <81.65%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.49% <84.49%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [491 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...5b2eda5](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.72% -9.90%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7500 -18459
+ Misses 13492 5781 -7711
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.72% <ø> (-0.26%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [674 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...0b0f941](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 56.40% -9.22%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7592 -18367
+ Misses 13492 5697 -7795
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.40% <ø> (+0.43%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [672 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...07d921a](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `6.22%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 59.39% -6.23%
==========================================
Files 834 818 -16
Lines 39559 39268 -291
Branches 3610 3450 -160
==========================================
- Hits 25959 23325 -2634
- Misses 13492 15765 +2273
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (-0.77%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `61.61% <87.35%> (+0.83%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.74% -9.88%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7503 -18456
+ Misses 13492 5778 -7714
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.74% <ø> (-0.24%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [674 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2db74eb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.78%`.
> The diff coverage is `84.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.84% -3.79%
==========================================
Files 834 854 +20
Lines 39559 40244 +685
Branches 3610 3613 +3
==========================================
- Hits 25959 24887 -1072
- Misses 13492 15176 +1684
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.60% <ø> (-0.11%)` | :arrow_down: |
| #python | `61.39% <84.42%> (+0.61%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `79.06% <79.06%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `84.61% <84.61%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <86.66%> (ø)` | |
| ... and [225 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2fd01fb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.68%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.93% -3.69%
==========================================
Files 834 856 +22
Lines 39559 40596 +1037
Branches 3610 3662 +52
==========================================
- Hits 25959 25142 -817
- Misses 13492 15273 +1781
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `61.49% <87.35%> (+0.71%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [254 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.75%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.86% -9.76%
==========================================
Files 834 406 -428
Lines 39559 13601 -25958
Branches 3610 3450 -160
==========================================
- Hits 25959 7598 -18361
+ Misses 13492 5833 -7659
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.86% <ø> (-0.12%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [673 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 56.38% -9.24%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7589 -18370
+ Misses 13492 5700 -7792
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.38% <ø> (+0.40%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [672 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2fd01fb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `5.98%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 59.63% -5.99%
==========================================
Files 834 818 -16
Lines 39559 39268 -291
Branches 3610 3450 -160
==========================================
- Hits 25959 23418 -2541
- Misses 13492 15681 +2189
- Partials 108 169 +61
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.90% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `61.61% <87.35%> (+0.83%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [341 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#discussion_r509689610
##########
File path: superset/annotation_layers/annotations/commands/create.py
##########
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from datetime import datetime
+from typing import Any, Dict, List, Optional
+
+from flask_appbuilder.models.sqla import Model
+from flask_appbuilder.security.sqla.models import User
+from marshmallow import ValidationError
+
+from superset.annotation_layers.annotations.commands.exceptions import (
+ AnnotationCreateFailedError,
+ AnnotationDatesValidationError,
+ AnnotationInvalidError,
+ AnnotationUniquenessValidationError,
+)
+from superset.annotation_layers.annotations.dao import AnnotationDAO
+from superset.annotation_layers.commands.exceptions import AnnotationLayerNotFoundError
+from superset.annotation_layers.dao import AnnotationLayerDAO
+from superset.commands.base import BaseCommand
+from superset.dao.exceptions import DAOCreateFailedError
+
+logger = logging.getLogger(__name__)
+
+
+class CreateAnnotationCommand(BaseCommand):
+ def __init__(self, user: User, data: Dict[str, Any]):
+ self._actor = user
+ self._properties = data.copy()
+
+ def run(self) -> Model:
+ self.validate()
+ try:
+ annotation = AnnotationDAO.create(self._properties)
+ except DAOCreateFailedError as ex:
+ logger.exception(ex.exception)
+ raise AnnotationCreateFailedError()
+ return annotation
+
+ def validate(self) -> None:
+ exceptions: List[ValidationError] = list()
+ layer_id: Optional[int] = self._properties.get("layer")
+ start_dttm: Optional[datetime] = self._properties.get("start_dttm")
+ end_dttm: Optional[datetime] = self._properties.get("end_dttm")
+ short_descr = self._properties.get("short_descr", "")
+
+ # Validate/populate model exists
+ if not layer_id and not isinstance(layer_id, int):
+ raise AnnotationLayerNotFoundError
Review comment:
missing instantiation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.71%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 60.90% -4.72%
==========================================
Files 834 412 -422
Lines 39559 25636 -13923
Branches 3610 0 -3610
==========================================
- Hits 25959 15614 -10345
+ Misses 13492 10022 -3470
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.90% <87.35%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `81.65% <81.65%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.49% <84.49%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...5b2eda5](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.02%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.60% -4.03%
==========================================
Files 834 412 -422
Lines 39559 25667 -13892
Branches 3610 0 -3610
==========================================
- Hits 25959 15811 -10148
+ Misses 13492 9856 -3636
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.60% <87.35%> (+0.81%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [492 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...72962c3](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.14%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.47% -4.15%
==========================================
Files 834 412 -422
Lines 39559 25647 -13912
Branches 3610 0 -3610
==========================================
- Hits 25959 15767 -10192
+ Misses 13492 9880 -3612
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.47% <87.35%> (+0.69%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `81.65% <81.65%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.49% <84.49%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...5b2eda5](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.72%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 60.89% -4.73%
==========================================
Files 834 412 -422
Lines 39559 25647 -13912
Branches 3610 0 -3610
==========================================
- Hits 25959 15617 -10342
+ Misses 13492 10030 -3462
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.89% <87.35%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `81.65% <81.65%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.49% <84.49%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [494 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...5b2eda5](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.73% -9.89%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7501 -18458
+ Misses 13492 5780 -7712
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.73% <ø> (-0.25%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [674 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2fd01fb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#discussion_r509659039
##########
File path: superset/annotation_layers/annotations/dao.py
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import List, Optional
+
+from sqlalchemy.exc import SQLAlchemyError
+
+from superset.dao.base import BaseDAO
+from superset.dao.exceptions import DAODeleteFailedError
+from superset.extensions import db
+from superset.models.annotations import Annotation
+
+logger = logging.getLogger(__name__)
+
+
+class AnnotationDAO(BaseDAO):
+ model_cls = Annotation
+
+ @staticmethod
+ def bulk_delete(models: Optional[List[Annotation]], commit: bool = True) -> None:
+ item_ids = [model.id for model in models] if models else []
+ try:
+ db.session.query(Annotation).filter(Annotation.id.in_(item_ids)).delete(
+ synchronize_session="fetch"
+ )
+ if commit:
+ db.session.commit()
+ except SQLAlchemyError:
+ if commit:
+ db.session.rollback()
+ raise DAODeleteFailedError()
+
+ @staticmethod
+ def validate_uniqueness(layer_id: int, short_descr: str) -> bool:
+ query = db.session.query(Annotation).filter(
+ Annotation.short_descr == short_descr, Annotation.layer_id == layer_id
+ )
+ return not db.session.query(query.exists()).scalar()
+
+ @staticmethod
+ def validate_update_uniqueness(
Review comment:
I like that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.79%`.
> The diff coverage is `84.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.82% -3.80%
==========================================
Files 834 854 +20
Lines 39559 40244 +685
Branches 3610 3613 +3
==========================================
- Hits 25959 24881 -1078
- Misses 13492 15182 +1690
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.60% <ø> (-0.11%)` | :arrow_down: |
| #python | `61.37% <84.42%> (+0.58%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `79.06% <79.06%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `84.61% <84.61%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <86.66%> (ø)` | |
| ... and [228 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2fd01fb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `5.14%`.
> The diff coverage is `84.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 60.47% -5.15%
==========================================
Files 834 410 -424
Lines 39559 25466 -14093
Branches 3610 0 -3610
==========================================
- Hits 25959 15400 -10559
+ Misses 13492 10066 -3426
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.47% <84.42%> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `79.06% <79.06%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `84.61% <84.61%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <86.66%> (ø)` | |
| ... and [493 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2fd01fb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `10.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
===========================================
- Coverage 65.62% 55.21% -10.41%
===========================================
Files 834 406 -428
Lines 39559 13601 -25958
Branches 3610 3450 -160
===========================================
- Hits 25959 7510 -18449
+ Misses 13492 5913 -7579
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (-0.77%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [675 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.75% -9.87%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7504 -18455
+ Misses 13492 5777 -7715
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.75% <ø> (-0.23%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [674 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...07d921a](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `10.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
===========================================
- Coverage 65.62% 55.33% -10.29%
===========================================
Files 834 406 -428
Lines 39559 13564 -25995
Branches 3610 3443 -167
===========================================
- Hits 25959 7506 -18453
+ Misses 13492 5880 -7612
- Partials 108 178 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.33% <ø> (-0.64%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `2.43% <0.00%> (-94.86%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [675 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...d25dfb0](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 56.40% -9.23%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7591 -18368
+ Misses 13492 5698 -7794
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.40% <ø> (+0.42%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [672 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2db74eb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.98%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.63% -3.99%
==========================================
Files 834 856 +22
Lines 39559 40596 +1037
Branches 3610 3662 +52
==========================================
- Hits 25959 25020 -939
- Misses 13492 15395 +1903
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `61.02% <87.35%> (+0.24%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [257 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 62.60% -3.02%
==========================================
Files 834 444 -390
Lines 39559 14776 -24783
Branches 3610 3613 +3
==========================================
- Hits 25959 9251 -16708
+ Misses 13492 5344 -8148
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.60% <ø> (-0.11%)` | :arrow_down: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [574 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...eed4d00](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.58%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 62.03% -3.59%
==========================================
Files 834 856 +22
Lines 39559 40596 +1037
Branches 3610 3662 +52
==========================================
- Hits 25959 25184 -775
- Misses 13492 15231 +1739
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `61.66% <87.35%> (+0.88%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [252 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 55.98% -9.64%
==========================================
Files 834 406 -428
Lines 39559 13564 -25995
Branches 3610 3443 -167
==========================================
- Hits 25959 7594 -18365
+ Misses 13492 5800 -7692
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.98% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `2.43% <0.00%> (-94.86%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [673 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...d25dfb0](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.00%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.61% -4.01%
==========================================
Files 834 412 -422
Lines 39559 25667 -13892
Branches 3610 0 -3610
==========================================
- Hits 25959 15815 -10144
+ Misses 13492 9852 -3640
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.61% <87.35%> (+0.83%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.20%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.41% -4.21%
==========================================
Files 834 412 -422
Lines 39559 25647 -13912
Branches 3610 0 -3610
==========================================
- Hits 25959 15752 -10207
+ Misses 13492 9895 -3597
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.41% <87.35%> (+0.63%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `81.65% <81.65%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.49% <84.49%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [489 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...5b2eda5](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.29%`.
> The diff coverage is `85.01%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.32% -4.30%
==========================================
Files 834 410 -424
Lines 39559 25469 -14090
Branches 3610 0 -3610
==========================================
- Hits 25959 15618 -10341
+ Misses 13492 9851 -3641
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.32% <85.01%> (+0.53%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `80.62% <80.62%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <88.46%> (ø)` | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...bf9baf4](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.79%`.
> The diff coverage is `87.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.82% -3.80%
==========================================
Files 834 856 +22
Lines 39559 40588 +1029
Branches 3610 3662 +52
==========================================
- Hits 25959 25093 -866
- Misses 13492 15314 +1822
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `61.32% <87.42%> (+0.54%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [262 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2c13931](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.14%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.48% -4.15%
==========================================
Files 834 412 -422
Lines 39559 25647 -13912
Branches 3610 0 -3610
==========================================
- Hits 25959 15768 -10191
+ Misses 13492 9879 -3613
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.48% <87.35%> (+0.69%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `81.65% <81.65%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.49% <84.49%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `86.20% <86.20%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [486 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...d25dfb0](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `9.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 56.37% -9.25%
==========================================
Files 834 406 -428
Lines 39559 13459 -26100
Branches 3610 3404 -206
==========================================
- Hits 25959 7588 -18371
+ Misses 13492 5701 -7791
- Partials 108 170 +62
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.37% <ø> (+0.40%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [672 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...0b0f941](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.30%`.
> The diff coverage is `85.01%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.31% -4.31%
==========================================
Files 834 410 -424
Lines 39559 25469 -14090
Branches 3610 0 -3610
==========================================
- Hits 25959 15617 -10342
+ Misses 13492 9852 -3640
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.31% <85.01%> (+0.53%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `80.62% <80.62%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <88.46%> (ø)` | |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...bf9baf4](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.80%`.
> The diff coverage is `84.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.82% -3.81%
==========================================
Files 834 854 +20
Lines 39559 40244 +685
Branches 3610 3613 +3
==========================================
- Hits 25959 24879 -1080
- Misses 13492 15184 +1692
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.60% <ø> (-0.11%)` | :arrow_down: |
| #python | `61.36% <84.42%> (+0.58%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `79.06% <79.06%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `84.61% <84.61%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <86.66%> (ø)` | |
| ... and [230 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2fd01fb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.05%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.56% -4.06%
==========================================
Files 834 856 +22
Lines 39559 40585 +1026
Branches 3610 3662 +52
==========================================
- Hits 25959 24988 -971
- Misses 13492 15416 +1924
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `60.92% <87.35%> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [264 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#discussion_r509509503
##########
File path: superset/annotation_layers/annotations/dao.py
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import List, Optional
+
+from sqlalchemy.exc import SQLAlchemyError
+
+from superset.dao.base import BaseDAO
+from superset.dao.exceptions import DAODeleteFailedError
+from superset.extensions import db
+from superset.models.annotations import Annotation
+
+logger = logging.getLogger(__name__)
+
+
+class AnnotationDAO(BaseDAO):
+ model_cls = Annotation
+
+ @staticmethod
+ def bulk_delete(models: Optional[List[Annotation]], commit: bool = True) -> None:
+ item_ids = [model.id for model in models] if models else []
+ try:
+ db.session.query(Annotation).filter(Annotation.id.in_(item_ids)).delete(
+ synchronize_session="fetch"
+ )
+ if commit:
+ db.session.commit()
+ except SQLAlchemyError:
+ if commit:
+ db.session.rollback()
+ raise DAODeleteFailedError()
+
+ @staticmethod
+ def validate_uniqueness(layer_id: int, short_descr: str) -> bool:
+ query = db.session.query(Annotation).filter(
+ Annotation.short_descr == short_descr, Annotation.layer_id == layer_id
+ )
+ return not db.session.query(query.exists()).scalar()
+
+ @staticmethod
+ def validate_update_uniqueness(
Review comment:
I think `validate_uniqueness` and `validate_update_uniqueness` could be combined to a single method with the signature of `validate_update_uniqueness`. `annotation_id` could be null when validating uniqueness on create.
##########
File path: superset/annotation_layers/dao.py
##########
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import List, Optional, Union
+
+from sqlalchemy.exc import SQLAlchemyError
+
+from superset.dao.base import BaseDAO
+from superset.dao.exceptions import DAODeleteFailedError
+from superset.extensions import db
+from superset.models.annotations import Annotation, AnnotationLayer
+
+logger = logging.getLogger(__name__)
+
+
+class AnnotationLayerDAO(BaseDAO):
+ model_cls = AnnotationLayer
+
+ @staticmethod
+ def bulk_delete(
+ models: Optional[List[AnnotationLayer]], commit: bool = True
+ ) -> None:
+ item_ids = [model.id for model in models] if models else []
+ try:
+ db.session.query(AnnotationLayer).filter(
+ AnnotationLayer.id.in_(item_ids)
+ ).delete(synchronize_session="fetch")
+ if commit:
+ db.session.commit()
+ except SQLAlchemyError:
+ if commit:
+ db.session.rollback()
+ raise DAODeleteFailedError()
+
+ @staticmethod
+ def has_annotations(model_id: Union[int, List[int]]) -> bool:
+ if isinstance(model_id, list):
+ return (
+ db.session.query(AnnotationLayer)
+ .filter(AnnotationLayer.id.in_(model_id))
+ .join(Annotation)
+ .first()
+ ) is not None
+ return (
+ db.session.query(AnnotationLayer)
+ .filter(AnnotationLayer.id == model_id)
+ .join(Annotation)
+ .first()
+ ) is not None
+
+ @staticmethod
+ def validate_name_uniqueness(name: str) -> bool:
+ query = db.session.query(AnnotationLayer).filter(AnnotationLayer.name == name)
+ return not db.session.query(query.exists()).scalar()
+
+ @staticmethod
+ def validate_update_name_uniqueness(layer_id: int, name: str) -> bool:
Review comment:
Same comment here: `validate_name_uniqueness` and `validate_update_name_uniqueness` could be a single method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.27%`.
> The diff coverage is `85.01%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.34% -4.28%
==========================================
Files 834 410 -424
Lines 39559 25469 -14090
Branches 3610 0 -3610
==========================================
- Hits 25959 15625 -10334
+ Misses 13492 9844 -3648
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.34% <85.01%> (+0.56%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `80.62% <80.62%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <88.46%> (ø)` | |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...bf9baf4](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `2.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 62.67% -2.95%
==========================================
Files 834 444 -390
Lines 39559 14929 -24630
Branches 3610 3662 +52
==========================================
- Hits 25959 9357 -16602
+ Misses 13492 5391 -8101
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [584 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.70%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 60.91% -4.71%
==========================================
Files 834 412 -422
Lines 39559 25665 -13894
Branches 3610 0 -3610
==========================================
- Hits 25959 15633 -10326
+ Misses 13492 10032 -3460
+ Partials 108 0 -108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.91% <87.35%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...72962c3](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `3.77%`.
> The diff coverage is `84.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.84% -3.78%
==========================================
Files 834 854 +20
Lines 39559 40244 +685
Branches 3610 3613 +3
==========================================
- Hits 25959 24890 -1069
- Misses 13492 15173 +1681
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.60% <ø> (-0.11%)` | :arrow_down: |
| #python | `61.40% <84.42%> (+0.62%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `78.57% <78.57%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `79.06% <79.06%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `81.25% <81.25%> (ø)` | |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `84.61% <84.61%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `84.61% <84.61%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <86.66%> (ø)` | |
| ... and [224 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...2db74eb](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11344: feat: annotations REST API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11344:
URL: https://github.com/apache/incubator-superset/pull/11344#issuecomment-712776063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=h1) Report
> Merging [#11344](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc03549299d3ad9ec7b294414c326da5b6f675ba?el=desc) will **decrease** coverage by `4.01%`.
> The diff coverage is `87.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11344 +/- ##
==========================================
- Coverage 65.62% 61.60% -4.02%
==========================================
Files 834 856 +22
Lines 39559 40585 +1026
Branches 3610 3662 +52
==========================================
- Hits 25959 25001 -958
- Misses 13492 15403 +1911
- Partials 108 181 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
| #python | `60.97% <87.35%> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <50.00%> (-2.94%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <82.14%> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <84.84%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <85.18%> (ø)` | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <85.71%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <86.66%> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `87.09% <87.09%> (ø)` | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | `87.50% <87.50%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <88.23%> (ø)` | |
| ... and [261 more](https://codecov.io/gh/apache/incubator-superset/pull/11344/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=footer). Last update [fc03549...985a51d](https://codecov.io/gh/apache/incubator-superset/pull/11344?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org