You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/13 15:37:48 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #2408: [Bug][Core] Fixed the bug that BigDecimal could not be converted correctly
TyrantLucifer opened a new pull request, #2408:
URL: https://github.com/apache/incubator-seatunnel/pull/2408
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
#2405
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2408: [Bug][Core] Fixed the bug that BigDecimal could not be converted correctly
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2408:
URL: https://github.com/apache/incubator-seatunnel/pull/2408#discussion_r945163879
##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/common/serialization/InternalRowConverter.java:
##########
@@ -80,6 +82,8 @@ private static Object convert(Object field, SeaTunnelDataType<?> dataType) {
return convertMap((Map<?, ?>) field, (MapType<?, ?>) dataType, InternalRowConverter::convert);
case STRING:
return UTF8String.fromString((String) field);
+ case DECIMAL:
+ return Decimal.apply((BigDecimal) field);
Review Comment:
Please add `DECIMAL` type processing in `InternalRowConverter#reconvert(Object, SeaTunnelDataType<?>)`;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2408: [Bug][Core] Fixed the bug that BigDecimal could not be converted correctly
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2408:
URL: https://github.com/apache/incubator-seatunnel/pull/2408#discussion_r945166034
##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/common/serialization/InternalRowConverter.java:
##########
@@ -80,6 +82,8 @@ private static Object convert(Object field, SeaTunnelDataType<?> dataType) {
return convertMap((Map<?, ?>) field, (MapType<?, ?>) dataType, InternalRowConverter::convert);
case STRING:
return UTF8String.fromString((String) field);
+ case DECIMAL:
+ return Decimal.apply((BigDecimal) field);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2408: [Bug][Core] Fixed the bug that BigDecimal could not be converted correctly
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2408:
URL: https://github.com/apache/incubator-seatunnel/pull/2408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org