You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/09/06 14:34:08 UTC

[GitHub] [commons-lang] garydgregory commented on issue #452: [LANG-1486] Generify builder classes Diffable, DiffBuilder, and

garydgregory commented on issue #452: [LANG-1486] Generify builder classes Diffable, DiffBuilder, and
URL: https://github.com/apache/commons-lang/pull/452#issuecomment-528879257
 
 
   > 
   > 
   > Well, after thinking about it, I'm not sure how we should deal with custom comparisons between two objects of different Type, or even add arbitrary differences to a diff, even if it's not related to one of the fields of the base object
   
   Yes, that's a concern but what we started with assumes that the type is the same. Feel free to continue the discussion on the dev mailing list and propose a PR :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services