You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2011/04/28 16:34:07 UTC
svn commit: r1097480 -
/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
Author: pete
Date: Thu Apr 28 14:34:07 2011
New Revision: 1097480
URL: http://svn.apache.org/viewvc?rev=1097480&view=rev
Log:
fix javadoc
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java?rev=1097480&r1=1097479&r2=1097480&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java Thu Apr 28 14:34:07 2011
@@ -315,7 +315,7 @@ public interface IResourceSettings
/**
* Placeholder string for '..' within resource urls (which will be crippled by the browser and
- * not work anymore). Note that by default the placeholder string is empty '' and thus will not
+ * not work anymore). Note that by default the placeholder string is <code>null</code> and thus will not
* allow to access parent folders. That is by purpose and for security reasons (see
* Wicket-1992). In case you really need it, a good value for placeholder would e.g. be "$up$".
* Resources additionally are protected by a
Re: svn commit: r1097480 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
Posted by Peter Ertl <pe...@gmx.org>.
should be fixed for 1.4 now
Am 28.04.2011 um 19:33 schrieb Peter Ertl:
> doing a quick check it seems that setting 'null' works for 1.5-trunk (no /null/null/ ... inside the path)
>
> probably this is 1.4 only
>
>
> Am 28.04.2011 um 19:29 schrieb Peter Ertl:
>
>> it's not supposed to be a fix, I just corrected the javadoc... the issue itself is still unresolved, that's why I ommitted the ticket number
>>
>> Am 28.04.2011 um 17:06 schrieb Martin Grigorov:
>>
>>> Please mention the ticket number in the commit messages.
>>>
>>> I am not sure whether this is fix is correct. With 'null' now it
>>> produces urls like "/something/null/else.gif"
>>>
>>> On Thu, Apr 28, 2011 at 5:34 PM, <pe...@apache.org> wrote:
>>>> Author: pete
>>>> Date: Thu Apr 28 14:34:07 2011
>>>> New Revision: 1097480
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1097480&view=rev
>>>> Log:
>>>> fix javadoc
>>>>
>>>> Modified:
>>>> wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>>>>
>>>> Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>>>> URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java?rev=1097480&r1=1097479&r2=1097480&view=diff
>>>> ==============================================================================
>>>> --- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java (original)
>>>> +++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java Thu Apr 28 14:34:07 2011
>>>> @@ -315,7 +315,7 @@ public interface IResourceSettings
>>>>
>>>> /**
>>>> * Placeholder string for '..' within resource urls (which will be crippled by the browser and
>>>> - * not work anymore). Note that by default the placeholder string is empty '' and thus will not
>>>> + * not work anymore). Note that by default the placeholder string is <code>null</code> and thus will not
>>>> * allow to access parent folders. That is by purpose and for security reasons (see
>>>> * Wicket-1992). In case you really need it, a good value for placeholder would e.g. be "$up$".
>>>> * Resources additionally are protected by a
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Martin Grigorov
>>> jWeekend
>>> Training, Consulting, Development
>>> http://jWeekend.com
>>
>
Re: svn commit: r1097480 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
Posted by Peter Ertl <pe...@gmx.org>.
doing a quick check it seems that setting 'null' works for 1.5-trunk (no /null/null/ ... inside the path)
probably this is 1.4 only
Am 28.04.2011 um 19:29 schrieb Peter Ertl:
> it's not supposed to be a fix, I just corrected the javadoc... the issue itself is still unresolved, that's why I ommitted the ticket number
>
> Am 28.04.2011 um 17:06 schrieb Martin Grigorov:
>
>> Please mention the ticket number in the commit messages.
>>
>> I am not sure whether this is fix is correct. With 'null' now it
>> produces urls like "/something/null/else.gif"
>>
>> On Thu, Apr 28, 2011 at 5:34 PM, <pe...@apache.org> wrote:
>>> Author: pete
>>> Date: Thu Apr 28 14:34:07 2011
>>> New Revision: 1097480
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1097480&view=rev
>>> Log:
>>> fix javadoc
>>>
>>> Modified:
>>> wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>>>
>>> Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>>> URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java?rev=1097480&r1=1097479&r2=1097480&view=diff
>>> ==============================================================================
>>> --- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java (original)
>>> +++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java Thu Apr 28 14:34:07 2011
>>> @@ -315,7 +315,7 @@ public interface IResourceSettings
>>>
>>> /**
>>> * Placeholder string for '..' within resource urls (which will be crippled by the browser and
>>> - * not work anymore). Note that by default the placeholder string is empty '' and thus will not
>>> + * not work anymore). Note that by default the placeholder string is <code>null</code> and thus will not
>>> * allow to access parent folders. That is by purpose and for security reasons (see
>>> * Wicket-1992). In case you really need it, a good value for placeholder would e.g. be "$up$".
>>> * Resources additionally are protected by a
>>>
>>>
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>
Re: svn commit: r1097480 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
Posted by Peter Ertl <pe...@gmx.org>.
it's not supposed to be a fix, I just corrected the javadoc... the issue itself is still unresolved, that's why I ommitted the ticket number
Am 28.04.2011 um 17:06 schrieb Martin Grigorov:
> Please mention the ticket number in the commit messages.
>
> I am not sure whether this is fix is correct. With 'null' now it
> produces urls like "/something/null/else.gif"
>
> On Thu, Apr 28, 2011 at 5:34 PM, <pe...@apache.org> wrote:
>> Author: pete
>> Date: Thu Apr 28 14:34:07 2011
>> New Revision: 1097480
>>
>> URL: http://svn.apache.org/viewvc?rev=1097480&view=rev
>> Log:
>> fix javadoc
>>
>> Modified:
>> wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>>
>> Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>> URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java?rev=1097480&r1=1097479&r2=1097480&view=diff
>> ==============================================================================
>> --- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java (original)
>> +++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java Thu Apr 28 14:34:07 2011
>> @@ -315,7 +315,7 @@ public interface IResourceSettings
>>
>> /**
>> * Placeholder string for '..' within resource urls (which will be crippled by the browser and
>> - * not work anymore). Note that by default the placeholder string is empty '' and thus will not
>> + * not work anymore). Note that by default the placeholder string is <code>null</code> and thus will not
>> * allow to access parent folders. That is by purpose and for security reasons (see
>> * Wicket-1992). In case you really need it, a good value for placeholder would e.g. be "$up$".
>> * Resources additionally are protected by a
>>
>>
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
Re: svn commit: r1097480 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
Posted by Martin Grigorov <mg...@apache.org>.
Please mention the ticket number in the commit messages.
I am not sure whether this is fix is correct. With 'null' now it
produces urls like "/something/null/else.gif"
On Thu, Apr 28, 2011 at 5:34 PM, <pe...@apache.org> wrote:
> Author: pete
> Date: Thu Apr 28 14:34:07 2011
> New Revision: 1097480
>
> URL: http://svn.apache.org/viewvc?rev=1097480&view=rev
> Log:
> fix javadoc
>
> Modified:
> wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
>
> Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java
> URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java?rev=1097480&r1=1097479&r2=1097480&view=diff
> ==============================================================================
> --- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java (original)
> +++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/settings/IResourceSettings.java Thu Apr 28 14:34:07 2011
> @@ -315,7 +315,7 @@ public interface IResourceSettings
>
> /**
> * Placeholder string for '..' within resource urls (which will be crippled by the browser and
> - * not work anymore). Note that by default the placeholder string is empty '' and thus will not
> + * not work anymore). Note that by default the placeholder string is <code>null</code> and thus will not
> * allow to access parent folders. That is by purpose and for security reasons (see
> * Wicket-1992). In case you really need it, a good value for placeholder would e.g. be "$up$".
> * Resources additionally are protected by a
>
>
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com