[jira] [Reopened] (WICKET-4839) Date converters should use a new instance of DateFormat to be thread safe

["Emond Papegaaij (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij reopened WICKET-4839:
-------------------------------------


The quickstart attached to this ticket is invalid. SimpleDateFormat.toString is not an indication of the actual instance of SimpleDateFormat because the hashCode method is overridden to return the hash code of the pattern, which will always be the same. If you change the debug output to System.identityHashCode( dateFormat ), you'll see a new instance is used on every call. Therefore, I opt to undo the changed made for this ticket, because they are not needed. DateFormat.getInstance will not return the same instance twice.
                
> Date converters should use a new instance of DateFormat to be thread safe
> -------------------------------------------------------------------------
>
>                 Key: WICKET-4839
>                 URL: https://issues.apache.org/jira/browse/WICKET-4839
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.19, 6.2.0
>            Reporter: SoulSpirit
>            Assignee: Martin Grigorov
>             Fix For: 6.3.0, 1.5.9
>
>         Attachments: 0001-WICKET-4839-DateFormat-should-be-thread-safe.patch, quickstart.zip
>
>
> Please consider the linked issue WICKET-4833.
> I had to open a new issue because I cannot attach the quickstart project I've prepared to a closed issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira