You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by strongh <gi...@git.apache.org> on 2014/11/04 17:34:36 UTC
[GitHub] storm pull request: use configured local hostname for reporting me...
GitHub user strongh opened a pull request:
https://github.com/apache/storm/pull/306
use configured local hostname for reporting metrics and errors
This is a proposed fix for
https://issues.apache.org/jira/browse/STORM-546
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yieldbot/storm local-hostname-conf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/306.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #306
----
commit a370c16780d143eb756c428c4c6a26dac05de5ab
Author: Homer Strong <ho...@gmail.com>
Date: 2014-11-04T16:30:20Z
use configured local hostname for reporting metrics and errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by strongh <gi...@git.apache.org>.
Github user strongh commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62281137
@harshach oops! I've pushed a fix for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62281744
@strongh thanks for the quick fix. It looks good to me . +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62280673
@strongh I am seeing this build issue
Exception in thread "main" java.lang.RuntimeException: Unable to resolve symbol: STORM-LOCAL-HOSTNAME in this context, compiling:(backtype/storm/util.clj:213:3)
the above symbol comes from daemon/common.clj , thrift both of which can't be imported in util.clj due to Cyclic load dependency. If its not straightforward we can keep your initial changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/306
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by strongh <gi...@git.apache.org>.
Github user strongh commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62278834
@harshach it has been made so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62222089
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62243796
@strongh thanks for patch. Can we make this into a utils.clj function . Similar code is used in supervisor.clj too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use configured local hostname for reporting me...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/306#issuecomment-62295091
Looks good to me also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---